Skip to content

Use Locale.ROOT for identifier case conversions #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamw7 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use Locale.ROOT for identifier case conversions #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions code/protogen-maven-plugin/src/main/java/io/github/adamw7/tools/code/gen/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,28 +2,29 @@

import java.util.Arrays;
import java.util.List;
import java.util.Locale;
import java.util.regex.Pattern;

import com.google.protobuf.Descriptors.FieldDescriptor;

public class Utils {

private Utils() {}

public static String to(FieldDescriptor fieldDescriptor, String suffix) {
return Utils.firstToUpper(fieldDescriptor.getName()) + suffix;
}

public static String firstToLower(String string) {
return (String.valueOf(string.charAt(0)).toLowerCase() + string.substring(1));
return (String.valueOf(string.charAt(0)).toLowerCase(Locale.ROOT) + string.substring(1));
}

public static String firstToUpper(String string) {
return (firstUpper(string) + string.substring(1));
}

private static String firstUpper(String string) {
return String.valueOf(string.charAt(0)).toUpperCase();
return String.valueOf(string.charAt(0)).toUpperCase(Locale.ROOT);
}

public static String toUpperCamelCase(String s) {
Expand All @@ -36,7 +37,7 @@ public static String toUpperCamelCase(String s) {
}

static String toProperCase(String s) {
return s.substring(0, 1).toUpperCase() + s.substring(1).toLowerCase();
return s.substring(0, 1).toUpperCase(Locale.ROOT) + s.substring(1).toLowerCase(Locale.ROOT);
}

public static String getNextIfc(String className, List<FieldDescriptor> fields, FieldDescriptor requiredField) {
Expand Down