fix(IterableSQLDataSource): use column index instead of name in getNextFrom#181
Merged
Merged
Conversation
…xtFrom getString(name) returns the first matching column for duplicate names in joins, silently producing wrong row data. Switch to getString(i+1) to retrieve each column by its 1-based index. Extend happyPathMultiTable test to assert all 5 columns from the SALARY INNER JOIN PEOPLE result, including both duplicate ID columns. Fixes #9 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getNextFromwas callingresultSet.getString(columnName), which returns the first matching column when a query produces duplicate column names (e.g.SELECT * FROM a JOIN b ON a.id = b.idyields twoidcolumns). This silently produces wrong row data for the second and subsequent duplicate-named columns.resultSet.getString(i + 1)(1-based positional index), which always retrieves the correct column regardless of name duplication.happyPathMultiTabletest to assert all 5 columns from theSALARY INNER JOIN PEOPLEresult, including both duplicateIDcolumns at positions 0 and 2.Fixes issue #9 from issues.md.
Test plan
SQLDataSourceTest#happyPathMultiTablenow verifies all 5 join columns, including bothIDvaluesSQLDataSourceTestcases (6 total) pass withmvn test -pl data -Dtest=SQLDataSourceTest🤖 Generated with Claude Code