Skip to content

fix(IterableSQLDataSource): use column index instead of name in getNextFrom #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamw7 merged 1 commit into from
Jun 2, 2026
Merged

fix(IterableSQLDataSource): use column index instead of name in getNextFrom #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions data/src/main/java/io/github/adamw7/tools/data/source/db/IterableSQLDataSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ public void reset() {
}

protected static String[] getNextFrom(ResultSet resultSet) throws SQLException {
String[] columns = getColumnsFrom(resultSet);
String[] row = new String[columns.length];
for (int i = 0; i < columns.length; ++i) {
row[i] = resultSet.getString(columns[i]);
int columnCount = resultSet.getMetaData().getColumnCount();
String[] row = new String[columnCount];
for (int i = 0; i < columnCount; ++i) {
row[i] = resultSet.getString(i + 1);
}
return row;
}
Expand Down
11 changes: 9 additions & 2 deletions data/src/test/java/io/github/adamw7/tools/data/source/db/SQLDataSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,19 @@ public void happyPath(IterableSQLDataSource source) {
public void happyPathMultiTable(IterableSQLDataSource source) {
source.open();

assertEquals("ID", source.getColumnNames()[0]);
assertEquals("VALUE", source.getColumnNames()[1]);
String[] columnNames = source.getColumnNames();
assertEquals("ID", columnNames[0]);
assertEquals("VALUE", columnNames[1]);
assertEquals("ID", columnNames[2]);
assertEquals("NAME", columnNames[3]);
assertEquals("SURNAME", columnNames[4]);

String[] row = source.nextRow();
assertEquals("1", row[0]);
assertEquals("1000", row[1]);
assertEquals("1", row[2]);
assertEquals("Adam", row[3]);
assertEquals("W", row[4]);
Utils.close(source);
}

Expand Down