Skip to content

Remove new relic license key 40 char restriction#250

Merged
AjazSumaiya merged 3 commits into
developfrom
cext-4578
May 5, 2025
Merged

Remove new relic license key 40 char restriction#250
AjazSumaiya merged 3 commits into
developfrom
cext-4578

Conversation

@AjazSumaiya
Copy link
Copy Markdown
Contributor

@AjazSumaiya AjazSumaiya commented Apr 29, 2025

Description

When setting the log forwarding configuration, we are currently enforcing a 40 character NewRelic license key based on the documentation . This causes an issue for customers such as Alshaya, who are using the End of Life NRAK Newrelic keys that were 32 characters long mentioned here

Related Issue

https://jira.corp.adobe.com/browse/CEXT-4578
https://jira.corp.adobe.com/browse/CEXT-4511

Motivation and Context

How Has This Been Tested?

Manually Tested against dev4 -

  1. Set Log configs input license key of less than 40 chars
image
  1. Check in DynamoDb if the key is correct
image

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

brasewel
brasewel previously approved these changes Apr 29, 2025
dani97
dani97 previously approved these changes Apr 30, 2025
Comment thread package.json Outdated
{
"name": "@adobe/aio-cli-plugin-api-mesh",
"version": "5.3.1",
"version": "5.3.1-beta.1",
Copy link
Copy Markdown
Member

@kmaschi kmaschi Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bump the version to 5.3.2-beta.1 since 5.3.1 is released.

@AjazSumaiya AjazSumaiya dismissed stale reviews from dani97 and brasewel via 4fdc848 April 30, 2025 14:14
@AjazSumaiya AjazSumaiya merged commit 0dfdce9 into develop May 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants