Skip to content

Remove new relic license key 40 char restriction #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AjazSumaiya merged 3 commits into from
May 5, 2025
Merged

Remove new relic license key 40 char restriction #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d674da
refactor: removed Newrelic license 40 char restriction
AjazSumaiya Apr 29, 2025
d129e50
bump up package version
AjazSumaiya Apr 29, 2025
4fdc848
Update package version
AjazSumaiya Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@adobe/aio-cli-plugin-api-mesh",
"version": "5.3.1",
"version": "5.3.2-beta.1",
"description": "Adobe I/O CLI plugin to develop and manage API mesh sources",
"keywords": [
"oclif-plugin"
Expand Down
9 changes: 0 additions & 9 deletions src/commands/api-mesh/__tests__/set-log-forwarding.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,15 +115,6 @@ describe('SetLogForwardingCommand', () => {
);
});

test('throws an error if license key has wrong format', async () => {
promptInputSecret.mockResolvedValueOnce('wrongformat'); // Too short

const command = new SetLogForwardingCommand([], {});
await expect(command.run()).rejects.toThrow(
`The license key is in the wrong format. Expected: 40 characters (received: ${11})`,
);
});

test('prompts for missing destination', async () => {
parseSpy.mockResolvedValueOnce({
flags: {
Expand Down
7 changes: 1 addition & 6 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,6 @@ const destinations = {
if (!value) {
throw new Error('License key is required');
}
if (value.length !== 40) {
throw new Error(
`The license key is in the wrong format. Expected: 40 characters (received: ${value.length})`,
);
}
},
},
],
Expand Down Expand Up @@ -777,7 +772,7 @@ async function localToUTCTime(timeString) {
try {
//Get the local timezone
// takes the timezone where the javascript runtime is running
// reference https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/resolvedOptions#browser_compatibility:~:text=The%20value%20provided%20for%20this%20property%20in%20the%20options%20argument%2C%20with%20default%20filled%20in%20as%20needed.%20It%20is%20an%20IANA%20time%20zone%20name.%20The%20default%20is%20the%20runtime%27s%20default%20time%20zone.
// reference https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/resolvedOptions#browser_compatibility:~:text=The%20value%20provided%20for%20this%20property%20in%20the%20options%20argument%2C%20with%20default%20filled%20in%20as%20needed.%20It%20is%20an%20IANA%20time%20zone.%20The%20default%20is%20the%20runtime%27s%20default%20time%20zone.
const timeZone = Intl.DateTimeFormat().resolvedOptions().timeZone;

// Create a Date object from the formatted time string
Expand Down
Loading