fix(selectlist-item): SITES-24721 sync aria-selected after render (WC…AG 4.1.2)#409
Open
StoianLucian wants to merge 1 commit intomasterfrom
Open
fix(selectlist-item): SITES-24721 sync aria-selected after render (WC…AG 4.1.2)#409StoianLucian wants to merge 1 commit intomasterfrom
StoianLucian wants to merge 1 commit intomasterfrom
Conversation
…AG 4.1.2) When selection is applied before render() sets role="option", the selected setter runs without a role attribute and skips aria-selected; the subsequent early return prevents updating after role is assigned. Call _syncAriaSelected() after render so listbox options expose state to assistive technology. Skill-Version: cursor-toolkit/commit-and-pr v0.2.1 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When selection is applied before render() sets role="option", the selected setter runs without a role attribute and skips aria-selected; the subsequent early return prevents updating after role is assigned. Call _syncAriaSelected() after render so listbox options expose state to assistive technology.
Skill-Version: cursor-toolkit/commit-and-pr v0.2.1
Made-with: Cursor
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: