Skip to content

fix(selectlist-item): SITES-24721 sync aria-selected after render (WC…AG 4.1.2) #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StoianLucian wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −4
Open

fix(selectlist-item): SITES-24721 sync aria-selected after render (WC…AG 4.1.2) #409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions coral-component-list/src/scripts/SelectListItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,19 @@ const SelectListItem = Decorator(class extends BaseComponent(HTMLElement) {
return this._elements.icon;
}

/**
Sync aria-selected with {@link #selected} when the element has a role that supports it.
Must run after {@link #render} assigns the default {@code role="option"}, because selection
may be set before the role attribute exists (WCAG 4.1.2).
@private
*/
_syncAriaSelected() {
if (this.hasAttribute('role') &&
VALID_ARIA_SELECTED_ROLES_REGEXP.test(this.getAttribute('role'))) {
this.setAttribute('aria-selected', this._selected);
}
}

/**
Whether the item is selected.

Expand All @@ -172,10 +185,7 @@ const SelectListItem = Decorator(class extends BaseComponent(HTMLElement) {
this._reflectAttribute('selected', this.disabled ? false : this._selected);

this.classList.toggle('is-selected', this._selected);
if (this.hasAttribute('role') &&
VALID_ARIA_SELECTED_ROLES_REGEXP.test(this.getAttribute('role'))) {
this.setAttribute('aria-selected', this._selected);
}
this._syncAriaSelected();

// Toggle check icon
this._elements.checkIcon.hidden = !this._selected;
Expand Down Expand Up @@ -245,6 +255,8 @@ const SelectListItem = Decorator(class extends BaseComponent(HTMLElement) {

// Assign the content zones, moving them into place in the process
this.content = content;

this._syncAriaSelected();
}
});

Expand Down
9 changes: 9 additions & 0 deletions coral-component-list/src/tests/test.SelectList.Item.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ describe('SelectList.Item', function () {
const el = new SelectList.Item();
expect(el.selected).to.be.false;
});

it('should expose aria-selected after render when selected was set before role exists (SITES-24721)', function () {
const el = new SelectList.Item();
el.textContent = 'Default';
el.selected = true;
helpers.build(el);
expect(el.getAttribute('role')).to.equal('option');
expect(el.getAttribute('aria-selected')).to.equal('true');
});
});

describe('#disabled', function () {
Expand Down
Loading