fix: log errors on move failures so they appear in Cloudflare Logs - #266
Merged
Merged
Conversation
Both the move_failed (S3 list error) and partial_failure (per-file copy rejection) paths returned 500 silently with no console.error, producing empty Logs[] in Cloudflare Worker execution logs and making it impossible to diagnose the root cause in production (~155 silent 500s in 7 days). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bosschaert
approved these changes
Apr 29, 2026
adobe-bot
pushed a commit
that referenced
this pull request
Apr 29, 2026
## [1.6.1](v1.6.0...v1.6.1) (2026-04-29) ### Bug Fixes * log errors on move failures so they appear in Cloudflare Logs ([#266](#266)) ([84ac28f](84ac28f))
Collaborator
|
🎉 This PR is included in version 1.6.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
move_failed(S3 list error) andpartial_failure(per-file copy rejection) returned 500 silently with noconsole.error, producing emptyLogs[]in Cloudflare Worker execution logsTest plan
logs the error when S3 list throws— assertsconsole.erroris called onmove_failed; confirmed failing before fixlogs the error when a file copy rejects— assertsconsole.erroris called onpartial_failure; confirmed failing before fixnpm run lint && npm test— 0 failures🤖 Generated with Claude Code