Skip to content

fix(quick-edit): select block on click anywhere non-editable inside it - #723

Open
shsteimer wants to merge 2 commits into
mainfrom
blkclick
Open

fix(quick-edit): select block on click anywhere non-editable inside it#723
shsteimer wants to merge 2 commits into
mainfrom
blkclick

Conversation

@shsteimer

@shsteimer shsteimer commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Previously only clicking the hover pill triggered block triggerred selection; clicking the block body elsewhere (outside editable text/images) did nothing. This makes that less specific and should make it easier to select the block you want in layout mode.

Note: ?nx=blkclick doesn't work to test this. I had to do a chrome dev tools override so that when the page loads https://da.live/nx/public/plugins/quick-edit/quick-edit.js it gets export * from 'https://blkclick--da-nx--adobe.aem.live/nx/public/plugins/quick-edit/quick-edit.js'; as the content of that file.

If the pages scritps.js also loads a local version of quick-edit.js, then that also needs to be over-ridden.

Previously only the hover pill triggered block selection; clicking the
block body elsewhere (outside editable text/images) did nothing.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shsteimer
shsteimer requested a review from hannessolo September 4, 2026 14:36
@aem-code-sync

aem-code-sync Bot commented Sep 4, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@shsteimer
shsteimer marked this pull request as draft September 4, 2026 14:41
@shsteimer
shsteimer requested review from hannessolo and removed request for hannessolo September 4, 2026 14:41
@shsteimer
shsteimer marked this pull request as ready for review September 4, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant