Skip to content

fix(quick-edit): select block on click anywhere non-editable inside it #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shsteimer wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −1
Open

fix(quick-edit): select block on click anywhere non-editable inside it #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9b63c3
fix(quick-edit): select block on click anywhere non-editable inside it
shsteimer Sep 4, 2026
e1a9c60
Merge branch 'main' into blkclick
shsteimer Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion nx/public/plugins/quick-edit/src/selection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,10 +203,23 @@ export function setupNodeSelection(ctx) {
return;
}

if (!currentSelectedNode) return;
if (t.closest?.(OVERLAY_SELECTOR)
|| t.closest?.('picture')
|| t.closest?.('[data-prose-index]')) return;

const block = t.closest?.('[data-block-index]');
if (block) {
const node = blockSelectPayload(block);
if (!node) return;
if (currentSelectedNode?.anchorType === 'table'
&& currentSelectedNode.proseIndex === node.proseIndex) return;
blurActiveEditor();
clearHoverPill();
activeCtx?.port?.postMessage({ type: MESSAGE_TYPES.NODE_SELECT, payload: { node } });
return;
}

if (!currentSelectedNode) return;
const selectedEl = resolveSelectionElement(currentSelectedNode, document);
if (selectedEl?.contains?.(t)) return;
activeCtx?.port?.postMessage({
Expand Down
9 changes: 9 additions & 0 deletions test/nx/public/plugins/quick-edit/selection.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,15 @@ describe('quick-edit selection gestures', () => {
expect(posted.some((m) => m.type === 'node-select' && m.payload?.node === null)).to.equal(false);
});

it('posts node-select when clicking a non-editable area inside a block directly', () => {
const block = document.querySelector('[data-block-index="60"]');
block.dispatchEvent(new MouseEvent('mousedown', { bubbles: true }));
expect(posted).to.deep.include({
type: 'node-select',
payload: { node: { anchorType: 'table', proseIndex: 60 } },
});
});

it('clears the selection when clicking outside it', () => {
setSelectedNode({ anchorType: 'table', proseIndex: 50 });
document.querySelector('.no-index')
Expand Down
Loading