chore: review-readiness sweep - #248
Merged
Merged
Conversation
memory.ts was 207 lines (>200 bar); extract the six run* verb flows and their helpers into memory-verbs.ts, leaving memory.ts as thin commander wiring. No behavior change.
Contributor
|
🎉 PR Validation ✅ PASSED Commit: Checks:
Ready to merge! ✨ 🔗 View workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review-readiness sweep (post #238-#247)
Fresh-reviewer pass over the whole repo after the 10-PR merge burst. The repo held up well; this PR carries the one actionable finding, plus a clean bill of health on the rest.
Fixed
src/commands/memory.tswas 207 lines (over the 200 bar). Split along its natural seam: the sixrun*verb flows + their helpers move tosrc/commands/memory-verbs.ts(133 lines);memory.tskeeps the commander wiring + errorguard(81 lines). Test import retargeted to./memory-verbs.js. No behavior change.Checked, nothing to fix
src/sync/cycle.ts), no duplicated helpers (redactRemoteUrllives once insync/git/remote-url.ts, imported by all five callers).anyoutside tests.TODO/FIXME/XXX, no commented-out code. Multi-line comment blocks that remain are load-bearing security/concurrency WHY notes (e.g. theext::transport-helper RCE guard, the cross-processmutateVaultsConfiginvariant) - collapsing them would lose signal, left as-is.docs/architecture.md(vsarchitecture.svg), and CLAUDE.md layout all cross-checked against source - 20+ claims (flags, env vars,4243port,0600auth.json, six MCP tools, conflict-file naming) all verified, zero mismatches, zero typos, zero em dashes.dist/cli.jshelp for every subcommand in an isolated HOME - consistent tone, no typos.npm run verifygreen;test:coveragegreen (85.5% stmts, above the 65/70/70/70 thresholds).