chore: review-readiness sweep

src/commands/memory-verbs.ts

@@ -0,0 +1,133 @@
+import chalk from 'chalk';
+import { type TreeEntry } from '@agentage/memory-core';
+import { ensureDaemon } from '../lib/daemon-client.js';
+import { daemonDisabled } from '../lib/daemon-pref.js';
+import { createDirectClient, type MemoryClient } from '../lib/memory-client.js';
+import { loadVaultsConfig } from '../lib/vaults.js';
+
+// Default engine path (DO3/DO4): the daemon - single writer, autostarted - when reachable; the
+// in-process DirectClient as a seamless fallback (--no-daemon, sandbox/CI, or fork blocked).
+const resolveClient = async (): Promise<MemoryClient> => {
+  const direct = (): MemoryClient => createDirectClient(loadVaultsConfig().config);
+  if (daemonDisabled()) return direct();
+  const daemon = await ensureDaemon();
+  return daemon ?? direct();
+};
+
+const readStdin = async (): Promise<string> => {
+  const chunks: Buffer[] = [];
+  for await (const chunk of process.stdin) chunks.push(chunk as Buffer);
+  return Buffer.concat(chunks).toString('utf-8');
+};
+
+// --frontmatter must be a JSON object; a raw parser error or a non-object value is unfriendly.
+const parseFrontmatter = (raw?: string): Record<string, unknown> | undefined => {
+  if (!raw) return undefined;
+  let parsed: unknown;
+  try {
+    parsed = JSON.parse(raw);
+  } catch (err) {
+    const detail = err instanceof Error ? err.message : String(err);
+    throw new Error(`--frontmatter must be a JSON object, e.g. '{"tags":["x"]}': ${detail}`);
+  }
+  if (typeof parsed !== 'object' || parsed === null || Array.isArray(parsed))
+    throw new Error(`--frontmatter must be a JSON object, e.g. '{"tags":["x"]}'`);
+  return parsed as Record<string, unknown>;
+};
+
+const emit = (json: boolean, data: unknown, human: () => void): void => {
+  if (json) console.log(JSON.stringify(data, null, 2));
+  else human();
+};
+
+// Flatten a folder-tree to the file paths it contains, in tree order.
+const treeFiles = (entries: TreeEntry[]): string[] =>
+  entries.flatMap((e) => (e.type === 'file' ? [e.path] : e.entries ? treeFiles(e.entries) : []));
+
+export interface CommonOpts {
+  vault?: string;
+  json?: boolean;
+}
+
+export const runSearch = async (
+  query: string,
+  opts: CommonOpts & { limit?: string },
+  client?: MemoryClient
+): Promise<void> => {
+  const c = client ?? (await resolveClient());
+  const out = await c.search(query, {
+    vault: opts.vault,
+    limit: opts.limit ? Number.parseInt(opts.limit, 10) : undefined,
+  });
+  emit(opts.json ?? false, out, () => {
+    if (out.results.length === 0) console.log('No matches.');
+    for (const h of out.results) console.log(`${h.path}\n  ${chalk.gray(h.snippet)}`);
+  });
+};
+
+export const runRead = async (
+  ref: string,
+  opts: CommonOpts,
+  client?: MemoryClient
+): Promise<void> => {
+  const c = client ?? (await resolveClient());
+  const doc = await c.read(ref, { vault: opts.vault });
+  emit(opts.json ?? false, doc, () => console.log(doc.body));
+};
+
+export const runWrite = async (
+  ref: string,
+  opts: CommonOpts & { body?: string; frontmatter?: string },
+  client?: MemoryClient
+): Promise<void> => {
+  const c = client ?? (await resolveClient());
+  const inlineBody = opts.body !== undefined && opts.body !== '-';
+  if (!inlineBody && process.stdin.isTTY)
+    throw new Error('provide --body, or pipe content on stdin');
+  const body = inlineBody ? opts.body! : await readStdin();
+  const frontmatter = parseFrontmatter(opts.frontmatter);
+  const out = await c.write(ref, body, { vault: opts.vault, frontmatter });
+  emit(opts.json ?? false, out, () => console.log(chalk.green(`Wrote ${out.path}`)));
+};
+
+export const runEdit = async (
+  ref: string,
+  opts: CommonOpts & { old?: string; new?: string; body?: string; append?: boolean },
+  client?: MemoryClient
+): Promise<void> => {
+  const c = client ?? (await resolveClient());
+  if (opts.old === undefined && opts.body === undefined)
+    throw new Error('specify --old/--new for a replacement or --body to overwrite');
+  const op =
+    opts.old !== undefined
+      ? { mode: 'str_replace' as const, old_str: opts.old, new_str: opts.new ?? '' }
+      : { mode: opts.append ? ('append' as const) : ('replace' as const), body: opts.body };
+  const out = await c.edit(ref, op, { vault: opts.vault });
+  emit(opts.json ?? false, out, () => console.log(chalk.green(`Edited ${out.path}`)));
+};
+
+export const runList = async (
+  folder: string | undefined,
+  opts: CommonOpts,
+  client?: MemoryClient
+): Promise<void> => {
+  const c = client ?? (await resolveClient());
+  const out = await c.list(folder, { vault: opts.vault });
+  emit(opts.json ?? false, out, () => {
+    const files = treeFiles(out.entries);
+    if (files.length === 0) console.log('No documents.');
+    for (const p of files) console.log(p);
+  });
+};
+
+export const runDelete = async (
+  ref: string,
+  opts: CommonOpts,
+  client?: MemoryClient
+): Promise<void> => {
+  const c = client ?? (await resolveClient());
+  const out = await c.delete(ref, { vault: opts.vault });
+  emit(opts.json ?? false, out, () =>
+    console.log(`Deleted ${out.path} (recoverable from git history)`)
+  );
+};

src/commands/memory.test.ts

@@ -1,7 +1,7 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 import type { MemoryClient } from '../lib/memory-client.js';
 import { translateEngineMessage } from '../lib/memory-client.js';
-import { runDelete, runEdit, runList, runRead, runSearch, runWrite } from './memory.js';
+import { runDelete, runEdit, runList, runRead, runSearch, runWrite } from './memory-verbs.js';
 
 const client = (): MemoryClient => ({
   search: vi.fn(async () => ({

src/commands/memory.ts

@@ -1,141 +1,15 @@
 import chalk from 'chalk';
 import { type Command } from 'commander';
-import { type TreeEntry } from '@agentage/memory-core';
-import { ensureDaemon } from '../lib/daemon-client.js';
-import { daemonDisabled } from '../lib/daemon-pref.js';
+import { translateEngineMessage } from '../lib/memory-client.js';
 import {
-  createDirectClient,
-  translateEngineMessage,
-  type MemoryClient,
-} from '../lib/memory-client.js';
-import { loadVaultsConfig } from '../lib/vaults.js';
-
-// Default engine path (DO3/DO4): the daemon - single writer, autostarted - when reachable; the
-// in-process DirectClient as a seamless fallback (--no-daemon, sandbox/CI, or fork blocked).
-const resolveClient = async (): Promise<MemoryClient> => {
-  const direct = (): MemoryClient => createDirectClient(loadVaultsConfig().config);
-  if (daemonDisabled()) return direct();
-  const daemon = await ensureDaemon();
-  return daemon ?? direct();
-};
-
-const readStdin = async (): Promise<string> => {
-  const chunks: Buffer[] = [];
-  for await (const chunk of process.stdin) chunks.push(chunk as Buffer);
-  return Buffer.concat(chunks).toString('utf-8');
-};
-
-// --frontmatter must be a JSON object; a raw parser error or a non-object value is unfriendly.
-const parseFrontmatter = (raw?: string): Record<string, unknown> | undefined => {
-  if (!raw) return undefined;
-  let parsed: unknown;
-  try {
-    parsed = JSON.parse(raw);
-  } catch (err) {
-    const detail = err instanceof Error ? err.message : String(err);
-    throw new Error(`--frontmatter must be a JSON object, e.g. '{"tags":["x"]}': ${detail}`);
-  }
-  if (typeof parsed !== 'object' || parsed === null || Array.isArray(parsed))
-    throw new Error(`--frontmatter must be a JSON object, e.g. '{"tags":["x"]}'`);
-  return parsed as Record<string, unknown>;
-};
-
-const emit = (json: boolean, data: unknown, human: () => void): void => {
-  if (json) console.log(JSON.stringify(data, null, 2));
-  else human();
-};
-
-// Flatten a folder-tree to the file paths it contains, in tree order.
-const treeFiles = (entries: TreeEntry[]): string[] =>
-  entries.flatMap((e) => (e.type === 'file' ? [e.path] : e.entries ? treeFiles(e.entries) : []));
-
-interface CommonOpts {
-  vault?: string;
-  json?: boolean;
-}
-
-export const runSearch = async (
-  query: string,
-  opts: CommonOpts & { limit?: string },
-  client?: MemoryClient
-): Promise<void> => {
-  const c = client ?? (await resolveClient());
-  const out = await c.search(query, {
-    vault: opts.vault,
-    limit: opts.limit ? Number.parseInt(opts.limit, 10) : undefined,
-  });
-  emit(opts.json ?? false, out, () => {
-    if (out.results.length === 0) console.log('No matches.');
-    for (const h of out.results) console.log(`${h.path}\n  ${chalk.gray(h.snippet)}`);
-  });
-};
-
-export const runRead = async (
-  ref: string,
-  opts: CommonOpts,
-  client?: MemoryClient
-): Promise<void> => {
-  const c = client ?? (await resolveClient());
-  const doc = await c.read(ref, { vault: opts.vault });
-  emit(opts.json ?? false, doc, () => console.log(doc.body));
-};
-
-export const runWrite = async (
-  ref: string,
-  opts: CommonOpts & { body?: string; frontmatter?: string },
-  client?: MemoryClient
-): Promise<void> => {
-  const c = client ?? (await resolveClient());
-  const inlineBody = opts.body !== undefined && opts.body !== '-';
-  if (!inlineBody && process.stdin.isTTY)
-    throw new Error('provide --body, or pipe content on stdin');
-  const body = inlineBody ? opts.body! : await readStdin();
-  const frontmatter = parseFrontmatter(opts.frontmatter);
-  const out = await c.write(ref, body, { vault: opts.vault, frontmatter });
-  emit(opts.json ?? false, out, () => console.log(chalk.green(`Wrote ${out.path}`)));
-};
-
-export const runEdit = async (
-  ref: string,
-  opts: CommonOpts & { old?: string; new?: string; body?: string; append?: boolean },
-  client?: MemoryClient
-): Promise<void> => {
-  const c = client ?? (await resolveClient());
-  if (opts.old === undefined && opts.body === undefined)
-    throw new Error('specify --old/--new for a replacement or --body to overwrite');
-  const op =
-    opts.old !== undefined
-      ? { mode: 'str_replace' as const, old_str: opts.old, new_str: opts.new ?? '' }
-      : { mode: opts.append ? ('append' as const) : ('replace' as const), body: opts.body };
-  const out = await c.edit(ref, op, { vault: opts.vault });
-  emit(opts.json ?? false, out, () => console.log(chalk.green(`Edited ${out.path}`)));
-};
-
-export const runList = async (
-  folder: string | undefined,
-  opts: CommonOpts,
-  client?: MemoryClient
-): Promise<void> => {
-  const c = client ?? (await resolveClient());
-  const out = await c.list(folder, { vault: opts.vault });
-  emit(opts.json ?? false, out, () => {
-    const files = treeFiles(out.entries);
-    if (files.length === 0) console.log('No documents.');
-    for (const p of files) console.log(p);
-  });
-};
-
-export const runDelete = async (
-  ref: string,
-  opts: CommonOpts,
-  client?: MemoryClient
-): Promise<void> => {
-  const c = client ?? (await resolveClient());
-  const out = await c.delete(ref, { vault: opts.vault });
-  emit(opts.json ?? false, out, () =>
-    console.log(`Deleted ${out.path} (recoverable from git history)`)
-  );
-};
+  type CommonOpts,
+  runDelete,
+  runEdit,
+  runList,
+  runRead,
+  runSearch,
+  runWrite,
+} from './memory-verbs.js';
 
 const guard = (fn: () => Promise<void>): Promise<void> =>
   fn().catch((err: unknown) => {