Repository navigation
Fix the stubbed update checks and bump upload-artifact - #72
Merged
Merged
Conversation
The admin-request harness answered WordPress.org's update checks with an empty JSON object. wp_update_themes() reads themes, no_update and translations from any array it decodes without checking them, so on a site whose theme update transient was stale, as every fresh CI site's is, each admin request warned three times and failed its test: trunk's Tests run on the merge of #70 failed one row in Integration, the multisite lane and the lowest lane. The core check returns without offers and the plugin check skips an empty array, so only the theme check warned, and local runs whose transients were fresh never ran it. The reply carries empty plugins, themes, no_update and translations, which every check reads as no updates. Assisted-by: Claude Code:claude-opus-5-5
Bumps the github-actions group with 1 update: [actions/upload-artifact](https://github.com/actions/upload-artifact). Updates `actions/upload-artifact` from 7.0.1 to 7.0.2 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@043fb46...cf430e0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 7.0.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com> (cherry picked from commit dbc6d1c)
ahegyes
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Trunk's Tests run on the merge of #70 failed one row each in Integration, the multisite lane and the prefer-lowest lane. The admin-request harness answered WordPress.org's update checks with an empty JSON object, and
wp_update_themes()readsthemes,no_updateandtranslationsfrom any decoded array without checking them, so on a fresh site, whose theme update transient is stale, every admin request warned three times and the harness failed its test. The stub's reply now carries emptyplugins,themes,no_updateandtranslations, which every check reads as no updates. Dependabot's #71,actions/upload-artifact7.0.1 to 7.0.2 in Quality's build upload, rides along as its own commit.Affected packages
wp-framework-bootstrapwp-framework-sharedwp-framework-corewp-framework-settingswp-framework-woocommerceChecklist
composer quality-checkpasses locally (PHPCS, PHPStan and the tests)README.mdBreaking changes / migration notes
None: the change is in the Integration harness and one pinned action. Local runs with fresh update transients skip the theme check, so
composer quality-checkand the multisite lane ran afterwp transient delete update_themes --network(andupdate_plugins,update_core), which reproduced the failure before the fix.