Skip to content

Fix the stubbed update checks and bump upload-artifact #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahegyes merged 2 commits into from
Nov 9, 2026
Merged

Fix the stubbed update checks and bump upload-artifact #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b005d7e
Give the stubbed update checks the keys the theme check reads
ahegyes Nov 9, 2026
73d9213
Bump actions/upload-artifact
dependabot[bot] Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:

# A release ships neither config, and Plugin Check flags scoper.inc.php's missing direct-access guard.
- name: Upload the build
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
name: consumer-a
path: |
Expand Down
4 changes: 2 additions & 2 deletions tests/Integration/Support/admin-request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,11 +103,11 @@ static function ( int $level, string $message, string $file, int $line ) use ( &
'accepted_args' => 0,
);

// WordPress's update checks give WordPress.org a few seconds and warn when it answers late, which would fail the request's test, so they read an answer with no updates.
// WordPress's update checks give WordPress.org a few seconds and warn when it answers late, which would fail the request's test, so they read an answer listing no updates, with every key wp_update_themes() reads unguarded.
$wp_filter['pre_http_request'][10][] = array( // phpcs:ignore WordPress.WP.GlobalVariablesOverride.Prohibited -- Hooks the request before WordPress loads.
'function' => static fn ( mixed $response, array $args, string $url ): mixed => 1 === preg_match( '#^https?://api\.wordpress\.org/(core/version-check|plugins/update-check|themes/update-check)/#', $url ) ? array(
'headers' => array(),
'body' => '{}',
'body' => '{"plugins":[],"themes":[],"no_update":[],"translations":[]}',
'response' => array(
'code' => 200,
'message' => 'OK',
Expand Down
Loading