Conversation
| with: | ||
| node-version: ${{ matrix.node }} | ||
| cache: pnpm | ||
| architecture: ${{ matrix.settings.architecture }} |
There was a problem hiding this comment.
I removed architecture, maybe it is not needed?
There was a problem hiding this comment.
Turns out this was using Rosetta on the arm64 runner, see also #33 (comment).
| echo "IMAGE=node:${{ matrix.node }}-slim" >> $GITHUB_OUTPUT | ||
| echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_OUTPUT | ||
| - name: Install dependencies | ||
| run: pnpm install --force |
There was a problem hiding this comment.
I don't know if --force was important here, and whether it is appropriately replaced by the new behavior ...
|
To make CI pass, I upgraded to I don't know if we want to do either of those things at this point ... alternatively we can go back to the old action and to testing via Rosetta. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
andresovela
left a comment
andresovela
left a comment
There was a problem hiding this comment.
I don't really understand these changes but CI passes :D
| target: x86_64-pc-windows-msvc | ||
| architecture: x64 | ||
| - host: macos-latest | ||
| - host: macos-15-intel |
There was a problem hiding this comment.
I'm not sure how long Github will support Intel macs (considering that the latest release in only available on Apple silicon). I think testing under Rosetta could work for a longer time.
3 participants
Prompted by #30, this pins
rust-toolchain(0906482), but instead of pinningpnpm/action-setup, I'm trying to switch topnpm/setup(ac67062).See https://github.com/pnpm/action-setup#using-pnpmsetup-instead and https://github.com/pnpm/setup.
I don't know if that's better, but it seems to be the more modern approach.
I'm not even sure if that works, so let's see if CI passes ...