CI update #33
+25
−58
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,19 +24,15 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
| - uses: pnpm/setup@703c52620218391530e48b9e8870d5c0082e1b9b # v2.1.0 | ||
| with: | ||
| runtime: node@22 | ||
| cache: true | ||
| - name: Install | ||
| uses: dtolnay/rust-toolchain@6c977a6ca4077a0ceb28ffbe03f59d46e9ac8772 | ||
| with: | ||
| toolchain: stable | ||
| components: clippy, rustfmt | ||
| - name: Oxlint | ||
| run: pnpm lint | ||
| - name: Prettier | ||
|
|
@@ -100,15 +96,14 @@ jobs: | |
| runs-on: ${{ matrix.settings.host }} | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
| # Installed on the host so the container does not need pnpm; the workspace is mounted | ||
| # into it, so `npm run build` finds the napi CLI in node_modules. | ||
| - uses: pnpm/setup@703c52620218391530e48b9e8870d5c0082e1b9b # v2.1.0 | ||
| with: | ||
| runtime: node@22 | ||
| cache: true | ||
| - name: Install | ||
| uses: dtolnay/rust-toolchain@6c977a6ca4077a0ceb28ffbe03f59d46e9ac8772 | ||
| with: | ||
| toolchain: stable | ||
| targets: ${{ matrix.settings.target }} | ||
|
|
@@ -127,10 +122,6 @@ jobs: | |
| run: ${{ matrix.settings.setup }} | ||
| if: ${{ matrix.settings.setup }} | ||
| shell: bash | ||
| # The build downloads the matching prebuilt native SDK for the target, so these steps | ||
| # need network access. | ||
| # The image ships Rust 1.82, which predates edition 2024. That edition is required | ||
|
|
@@ -183,28 +174,19 @@ jobs: | |
| settings: | ||
| - host: windows-latest | ||
| target: x86_64-pc-windows-msvc | ||
| - host: macos-15-intel | ||
| target: x86_64-apple-darwin | ||
| - host: macos-latest | ||
| target: aarch64-apple-darwin | ||
| node: | ||
| - '22' | ||
| runs-on: ${{ matrix.settings.host }} | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
| - uses: pnpm/setup@703c52620218391530e48b9e8870d5c0082e1b9b # v2.1.0 | ||
| with: | ||
|
Collaborator
Author
There was a problem hiding this comment. I removed
Collaborator
Author
There was a problem hiding this comment. Turns out this was using Rosetta on the arm64 runner, see also #33 (comment). |
||
| runtime: node@${{ matrix.node }} | ||
| cache: true | ||
| - name: Download artifacts | ||
| uses: actions/download-artifact@v8 | ||
| with: | ||
|
|
@@ -234,13 +216,10 @@ jobs: | |
| runs-on: ${{ contains(matrix.target, 'aarch64') && 'ubuntu-24.04-arm' || 'ubuntu-latest' }} | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
| - uses: pnpm/setup@703c52620218391530e48b9e8870d5c0082e1b9b # v2.1.0 | ||
| with: | ||
| runtime: node@${{ matrix.node }} | ||
| cache: true | ||
| - name: Output docker params | ||
| id: docker | ||
| run: | | ||
|
|
@@ -253,8 +232,6 @@ jobs: | |
| " >> $GITHUB_OUTPUT | ||
| echo "IMAGE=node:${{ matrix.node }}-slim" >> $GITHUB_OUTPUT | ||
| echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_OUTPUT | ||
|
Collaborator
Author
There was a problem hiding this comment. I don't know if |
||
| - name: Download artifacts | ||
| uses: actions/download-artifact@v8 | ||
| with: | ||
|
|
@@ -282,15 +259,10 @@ jobs: | |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v7 | ||
| - uses: pnpm/setup@703c52620218391530e48b9e8870d5c0082e1b9b # v2.1.0 | ||
| with: | ||
| runtime: node@22 | ||
| cache: true | ||
| - name: Download artifacts | ||
| uses: actions/download-artifact@v8 | ||
| with: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -116,5 +116,5 @@ | |
| "singleQuote": true, | ||
| "arrowParens": "always" | ||
| }, | ||
| "packageManager": "pnpm@12.4.1" | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how long Github will support Intel macs (considering that the latest release in only available on Apple silicon). I think testing under Rosetta could work for a longer time.