passing request collection as to service#51
Open
alamriku wants to merge 1 commit intorefactor_dependencyfrom
Open
passing request collection as to service#51alamriku wants to merge 1 commit intorefactor_dependencyfrom
alamriku wants to merge 1 commit intorefactor_dependencyfrom
Conversation
me-shaon
reviewed
Dec 11, 2020
Collaborator
me-shaon
left a comment
me-shaon
left a comment
There was a problem hiding this comment.
Few minor issues commented on. Fix and merge the PR by yourself.
|
|
||
| public function destroy($user) | ||
| { | ||
| dd($user); |
| } | ||
|
|
||
| public function updateUser($request, $profile) | ||
| public function updateUser($request, $id) |
Collaborator
There was a problem hiding this comment.
Rename the parameter to $data, instead of $request. Update in all the methods in Service classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.