passing request collection as to service

app/Http/Controllers/AdminController.php

@@ -46,11 +46,6 @@ public function unBan(User $user)
         return redirect()->back()->with('success', 'User Status Changed');
     }
 
-    public function delete(User $user)
-    {
-        $user->delete();
-        return redirect()->back()->with('success', 'User Deleted');
-    }
 
     public function create()
     {
@@ -66,52 +61,8 @@ public function create()
 
     public function store(ProfileRequest $request)
     {
-        $this->userService->storeUser($request);
+        $this->userService->storeUser($request->all());
         return redirect()->back()->with('success', 'Librarian Added');
     }
 
-    /**
-     * Display the specified resource.
-     *
-     * @param  int  $id
-     * @return \Illuminate\Http\Response
-     */
-    public function show($id)
-    {
-        //
-    }
-
-    /**
-     * Show the form for editing the specified resource.
-     *
-     * @param  int  $id
-     * @return \Illuminate\Http\Response
-     */
-    public function edit($id)
-    {
-        //
-    }
-
-    /**
-     * Update the specified resource in storage.
-     *
-     * @param  \Illuminate\Http\Request  $request
-     * @param  int  $id
-     * @return \Illuminate\Http\Response
-     */
-    public function update(Request $request, $id)
-    {
-        //
-    }
-
-    /**
-     * Remove the specified resource from storage.
-     *
-     * @param  int  $id
-     * @return \Illuminate\Http\Response
-     */
-    public function destroy($id)
-    {
-        //
-    }
 }

app/Http/Controllers/AuthorController.php

@@ -45,7 +45,7 @@ public function create()
      */
     public function store(AuthorRequest $request)
     {
-        $this->authorService->storeAuthor($request);
+        $this->authorService->storeAuthor($request->all());
         return redirect()->back()->with('success', 'Author Added');
     }
 
@@ -80,7 +80,7 @@ public function edit(Author $author)
      */
     public function update(AuthorRequest $request, Author $author)
     {
-        $this->authorService->updateAuthor($request, $author);
+        $this->authorService->updateAuthor($request->all(), $author);
         return redirect()->back()->with('success', 'Author updated');
     }
 

app/Http/Controllers/UserController.php

@@ -27,8 +27,14 @@ public function dashboard()
 
     public function profileUpdate(ProfileRequest $request)
     {
-        $profile = $this->userService->getUser($request->id);
-        $this->userService->updateUser($request, $profile);
+
+        $this->userService->updateUser($request->all(), $request->id);
         return redirect()->back()->with('success', 'Profile updated');
     }
+
+    public function destroy(User $user)
+    {
+        $this->userService->destroy($user);
+        return redirect()->back()->with('success', 'User Deleted');
+    }
 }

app/Http/Requests/ProfileRequest.php

@@ -3,6 +3,7 @@
 namespace App\Http\Requests;
 
 use Illuminate\Foundation\Http\FormRequest;
+use Illuminate\Validation\Rule;
 
 class ProfileRequest extends FormRequest
 {
@@ -25,7 +26,10 @@ public function rules()
     {
         return [
             'name' => 'required',
-            'email' => 'required|email|unique:users',
+            'email' => [
+                'required',
+                Rule::unique('users')->ignore($this->id),
+            ],
             'password' => 'sometimes|confirmed'
         ];
     }

app/Services/AuthorService.php

@@ -3,6 +3,7 @@
 namespace App\Services;
 
 use App\Models\Author;
+use Illuminate\Support\Arr;
 
 class AuthorService
 {
@@ -16,8 +17,8 @@ public function __construct(FileService $file)
     public function storeAuthor($request)
     {
         $author = new Author();
-        $author->name = $request->name;
-        $author->description = $request->name;
+        $author->name = $request["name"];
+        $author->description = $request["description"];
         if ($request->hasFile('image')) {
             if ($request->file('image')->isValid()) {
                 $author->image = $this->file->storeFile($request->file('image'));
@@ -28,8 +29,8 @@ public function storeAuthor($request)
 
     public function updateAuthor($request, $author)
     {
-        $author->name = $request->name;
-        $author->description = $request->name;
+        $author->name = $request["name"];
+        $author->description = $request["description"];
         if ($request->hasFile('image')) {
             if ($request->file('image')->isValid()) {
                 $this->file->removeFile($author->image);

app/Services/UserService.php

@@ -9,27 +9,28 @@ class UserService
 {
     public function getUser($user)
     {
-        return User::where('id', $user)->first();
+        return User::find($user);
     }
 
-    public function updateUser($request, $profile)
+    public function updateUser($request, $id)
     {
-        $profile->name = $request->name;
-        $profile->email = $request->email;
-        if ($request->filled('password')) {
-            $profile->password = Hash::make($request->password);
+        $profile=$this->getUser($id);
+        $profile->name = $request['name'];
+        $profile->email = $request['email'];
+        if (isset($request['password'])) {
+            $profile->password = Hash::make($request['password']);
         }
         $profile->update();
     }
 
     public function storeUser($request)
     {
         $user = new User();
-        $user->name = $request->name;
-        $user->phone = $request->phone;
-        $user->email = $request->email;
+        $user->name = $request["name"];
+        $user->phone = $request["phone"];
+        $user->email = $request["email"];
         $user->role = User::ROLE_LIBRARIAN;
-        $user->password = Hash::make($request->password);
+        $user->password = Hash::make($request["password"]);
         $user->save();
     }
 
@@ -44,4 +45,10 @@ public function unBan($user)
         $user->is_banned = 0;
         $user->update();
     }
+
+    public function destroy($user)
+    {
+        dd($user);
+        $user->delete();
+    }
 }

resources/views/admin/user/list.blade.php

@@ -78,7 +78,7 @@ class="inline-flex items-center border border-gray-300 rounded-md shadow-sm text
 
                                         </button>
                                     </span>
-                                    <form action="{{route('user-delete',$user->id)}}" style="display: none;" id="delete-form{{$user->id}}" method="post">
+                                    <form action="{{route('user.destroy',$user)}}" style="display: none;" id="delete-form{{$user->id}}" method="post">
                                         @csrf
                                         @method("DELETE")
                                     </form>

routes/web.php

@@ -29,7 +29,7 @@
     Route::put('users/{user}/ban',[AdminController::class,'ban'])->name('ban');
     Route::put('users/{user}/un-ban',[AdminController::class,'unBan'])->name('unBan');
     Route::get('users',[AdminController::class,'index'])->name('user-list');
-    Route::delete('users/{user}/delete',[AdminController::class,'delete'])->name('user-delete');
+    Route::delete('users/{user}',[UserController::class,'destroy'])->name('user.destroy');
 });
 
 require __DIR__.'/auth.php';