Repository navigation
fix: the trigger test's instance chooses the law its searches cover - #104
Merged
Merged
Conversation
Signed-off-by: alkhatibdev <me@alkhatib.dev>
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trigger test's instance chooses the law its searches cover
Since #42 an instance searches nothing until somebody chooses the laws that apply to the
organisation, and refuses every search until then. The trigger test's throwaway instance never
chose any, so every
search_policiescall in a run came back as an error: "nobody has chosenwhich laws apply to this organisation yet, so nothing is searched." Nothing in the report showed
it: a run stops at its first answer, and an error is an answer.
What a run measures still held. It records the decision to search, and that decision comes
before the answer: in the batches run since #42, the only DPOLens call before the first search
was
list_documents, which never failed. The published numbers were measured on 8 and 9October, before #42.
It also explains the query log disagreeing with the stream in those batches: a refused search is
refused before it is logged, by design.
What changes
dpolens laws select gdpr), as the published runssearched it.
search_failedin its outcome, andthe report names it.
--writerefuses a batch with such a run, since its instance could not answer.evals/trigger/README.mdsays both.Batches recorded before this read as having no failed search.
Tests
names the run.
--writerefuses a batch whose searches came back as errors.Each fails without its change.