Repository navigation
refactor(session): reuse _stash_session_manager in SessionMiddleware.dispatch - #219
Merged
Merged
Conversation
…dispatch SessionMiddleware.dispatch repeated the helper's body inline, so the two copies could drift apart. No behaviour change. Closes #169
allen0099
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169 (part of #117)
SessionMiddleware.dispatchrepeated the body of_stash_session_managerinline, whileFastAPICacheXSessionMiddlewarealready called the helper. Both copies registered the manager onapp.stateon the first request only.dispatchnow calls the helper, so the two middlewares cannot drift apart.No behaviour change, so there is no CHANGELOG entry.
Tests
No new tests. The existing ones already cover this path: replacing the call with
passfails four tests intests/session/test_get_session_manager.py.Ruff,
mypy --strictand the full suite against live Redis and Memcached (897 passed).