Skip to content

refactor(session): reuse _stash_session_manager in SessionMiddleware.dispatch #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allen0099 merged 1 commit into from
Sep 26, 2026
Merged

refactor(session): reuse _stash_session_manager in SessionMiddleware.dispatch #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions fastapi_cachex/session/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,14 +220,7 @@ async def dispatch(
Returns:
Response
"""
# Store session manager in app state for dependency injection (first request only)
# This allows developers to use get_session_manager() dependency
if not hasattr(request.app.state, "__fastapi_cachex_session_manager"):
setattr(
request.app.state,
"__fastapi_cachex_session_manager",
self.session_manager,
)
_stash_session_manager(request.app, self.session_manager)

# Extract session token from request
token = self._extract_token(request)
Expand Down
Loading