Conversation
17 tasks
Codecov Report❌ Patch coverage is
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Commit: 2739c1f
|
prajwolrg
requested changes
May 22, 2026
Collaborator
prajwolrg
left a comment
prajwolrg
left a comment
There was a problem hiding this comment.
Thanks for adding this. One small nit and this should be good to go.
Comment on lines
+191
to
+196
| let selected_operator_raw = selected_operator.raw(); | ||
| let selected_operator_mode = if selected_operator.as_specific().is_some() { | ||
| "specific" | ||
| } else { | ||
| "any" | ||
| }; |
Collaborator
There was a problem hiding this comment.
We should add a Display trait to OperatorSelection so that this can be handled properly.
Member
Author
There was a problem hiding this comment.
Ok added a commit before the logs that derives Display see 5482d7c
barakshani
approved these changes
May 22, 2026
Comment on lines
+289
to
+294
| info!( | ||
| deposit_idx, | ||
| assignee = assignment.current_assignee(), | ||
| fulfillment_deadline = assignment.fulfillment_deadline(), | ||
| l1_height = current_block.height(), | ||
| "Reassigned expired withdrawal assignment", |
Collaborator
There was a problem hiding this comment.
reassignment are actually logged already, but this one is even better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When ASM processes a checkpoint with withdrawal intents, it does not log anything about it. We only learn about the assignment when the bridge processes the ASM output, which is a bit later as bridge waits for finality. For debugging purposes, this PR adds ability to track the entire progress, so a log from the bridge subprotocol is requested.
The log includes the deposit index and the assignee.
Type of Change
Notes to Reviewers
Checklist
Related Issues
STR-3557