Customize error when a player is not allowed to join a lobby#136
Open
leonardochaia wants to merge 1 commit into
Open
Customize error when a player is not allowed to join a lobby#136leonardochaia wants to merge 1 commit into
leonardochaia wants to merge 1 commit into
Conversation
k1l3s
approved these changes
Jan 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the signature of
BaseLobby.IsPlayerAllowedto include anout string errorparameter in order to be able to return an error instead of the default "Player is not allowed" message.Since this introduces a breaking change for classes who extend
BaseLobby, maybe you'd prefer if it would be added as an overload instead. That'd be fine, just let me know and I can implement it, although I believe you'd want to give the user a hint of why he/she is not allowed to join, hence I prefer that the implementation forces you to do so.Leo.