Skip to content

Customize error when a player is not allowed to join a lobby #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonardochaia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Customize error when a player is not allowed to join a lobby #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions ...erverFramework2/Assets/Barebones/Msf/Scripts/Modules/Lobbies/Implementations/BaseLobby.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,12 @@ public bool AddPlayer(LobbyUserExtension playerExt, out string error)
return false;
}

if (!IsPlayerAllowed(username, playerExt))
if (!IsPlayerAllowed(username, playerExt, out error))
{
error = "You're not allowed";
if (error == null || error == string.Empty)
{
error = "You're not allowed";
}
return false;
}

Expand Down Expand Up @@ -419,8 +422,9 @@ protected virtual string TryGetUsername(IPeer peer)
/// This will be called before adding a player to lobby.
/// Override it to add custom checks for bans and etc.
/// </summary>
protected virtual bool IsPlayerAllowed(string username, LobbyUserExtension user)
protected virtual bool IsPlayerAllowed(string username, LobbyUserExtension user, out string error)
{
error = "You're not allowed";
return true;
}

Expand Down