Fix manifest url formats and update link to mpd - #27
Conversation
|
tested on windows 10. builds and works. |
|
Hi! I've tried your fix, but still get en error( Is it different problem or I did something wrong? Traceback (most recent call last):
File "kinescope-dl.py", line 79, in <module>
main()
~~~~^^
File "click/core.py", line 1157, in __call__
File "click/core.py", line 1078, in main
File "click/core.py", line 1434, in invoke
File "click/core.py", line 783, in invoke
File "kinescope-dl.py", line 70, in main
downloader.download(
~~~~~~~~~~~~~~~~~~~^
output_file if output_file else f'{kinescope_video.video_id}.mp4',
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
chosen_resolution
^^^^^^^^^^^^^^^^^
)
^
File "kinescope/downloader.py", line 152, in download
...<3 lines>...
self._get_segments_urls(resolution)['video/mp4'],
^^^^^
File "kinescope/downloader.py", line 119, in _fetch_segments
self._fetch_segment(segment_url, f)
~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
File "kinescope/downloader.py", line 100, in _fetch_segment
BytesIO(self.http.get(segment_url, stream=True).content),
~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
File "requests/sessions.py", line 602, in get
File "requests/sessions.py", line 575, in request
File "requests/sessions.py", line 486, in prepare_request
File "requests/models.py", line 368, in prepare
File "requests/models.py", line 439, in prepare_url
requests.exceptions.MissingSchema: Invalid URL '0/78660149/360p.mp4?kcd=AAAAAABAr0A': No scheme supplied. Perhaps you meant https://0/78660149/360p.mp4?kcd=AAAAAABAr0A?
[PYI-1520:ERROR] Failed to execute script 'kinescope-dl' due to unhandled exception! |
Hi, looks like you use not fixed version. |
You need to checkout to the branch with the fix before building |
|
@akolnoochenko @Heiwa03 thanks guys! Just messed up with rebuilding 😢 Now it's working just fine! |
|
thank you, with this changes download start! this branch must be merged to main and publish new release |
|
This works, hell yeah |
|
Getting Not sure what i missed since i get not errors during building. |
Fixes issue #26