Skip to content

Fix manifest url formats and update link to mpd - #27

Open
akolnoochenko wants to merge 1 commit into
anijackich:masterfrom
akolnoochenko:manifest-update
Open

Fix manifest url formats and update link to mpd#27
akolnoochenko wants to merge 1 commit into
anijackich:masterfrom
akolnoochenko:manifest-update

Conversation

@akolnoochenko

Copy link
Copy Markdown

Fixes issue #26

@ilyagp ilyagp mentioned this pull request Nov 26, 2024
@Heiwa03

Heiwa03 commented Dec 2, 2024

Copy link
Copy Markdown

tested on windows 10. builds and works.

@Di9

Di9 commented Dec 7, 2024

Copy link
Copy Markdown

Hi! I've tried your fix, but still get en error( Is it different problem or I did something wrong?

Traceback (most recent call last):
  File "kinescope-dl.py", line 79, in <module>
    main()
    ~~~~^^
  File "click/core.py", line 1157, in __call__
  File "click/core.py", line 1078, in main
  File "click/core.py", line 1434, in invoke
  File "click/core.py", line 783, in invoke
  File "kinescope-dl.py", line 70, in main
    downloader.download(
    ~~~~~~~~~~~~~~~~~~~^
        output_file if output_file else f'{kinescope_video.video_id}.mp4',
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        chosen_resolution
        ^^^^^^^^^^^^^^^^^
    )
    ^
  File "kinescope/downloader.py", line 152, in download


    ...<3 lines>...
        self._get_segments_urls(resolution)['video/mp4'],
        ^^^^^
  File "kinescope/downloader.py", line 119, in _fetch_segments
    self._fetch_segment(segment_url, f)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "kinescope/downloader.py", line 100, in _fetch_segment
    BytesIO(self.http.get(segment_url, stream=True).content),
            ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "requests/sessions.py", line 602, in get
  File "requests/sessions.py", line 575, in request
  File "requests/sessions.py", line 486, in prepare_request
  File "requests/models.py", line 368, in prepare
  File "requests/models.py", line 439, in prepare_url
requests.exceptions.MissingSchema: Invalid URL '0/78660149/360p.mp4?kcd=AAAAAABAr0A': No scheme supplied. Perhaps you meant https://0/78660149/360p.mp4?kcd=AAAAAABAr0A?
[PYI-1520:ERROR] Failed to execute script 'kinescope-dl' due to unhandled exception!

@akolnoochenko

Copy link
Copy Markdown
Author

Hi! I've tried your fix, but still get en error( Is it different problem or I did something wrong?

Hi, looks like you use not fixed version.

@Heiwa03

Heiwa03 commented Dec 7, 2024

Copy link
Copy Markdown

Hi! I've tried your fix, but still get en error( Is it different problem or I did something wrong?

Traceback (most recent call last):
  File "kinescope-dl.py", line 79, in <module>
    main()
    ~~~~^^
  File "click/core.py", line 1157, in __call__
  File "click/core.py", line 1078, in main
  File "click/core.py", line 1434, in invoke
  File "click/core.py", line 783, in invoke
  File "kinescope-dl.py", line 70, in main
    downloader.download(
    ~~~~~~~~~~~~~~~~~~~^
        output_file if output_file else f'{kinescope_video.video_id}.mp4',
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        chosen_resolution
        ^^^^^^^^^^^^^^^^^
    )
    ^
  File "kinescope/downloader.py", line 152, in download


    ...<3 lines>...
        self._get_segments_urls(resolution)['video/mp4'],
        ^^^^^
  File "kinescope/downloader.py", line 119, in _fetch_segments
    self._fetch_segment(segment_url, f)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "kinescope/downloader.py", line 100, in _fetch_segment
    BytesIO(self.http.get(segment_url, stream=True).content),
            ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "requests/sessions.py", line 602, in get
  File "requests/sessions.py", line 575, in request
  File "requests/sessions.py", line 486, in prepare_request
  File "requests/models.py", line 368, in prepare
  File "requests/models.py", line 439, in prepare_url
requests.exceptions.MissingSchema: Invalid URL '0/78660149/360p.mp4?kcd=AAAAAABAr0A': No scheme supplied. Perhaps you meant https://0/78660149/360p.mp4?kcd=AAAAAABAr0A?
[PYI-1520:ERROR] Failed to execute script 'kinescope-dl' due to unhandled exception!

You need to checkout to the branch with the fix before building

@Di9

Di9 commented Dec 8, 2024

Copy link
Copy Markdown

@akolnoochenko @Heiwa03 thanks guys! Just messed up with rebuilding 😢 Now it's working just fine!

@aidolov23

Copy link
Copy Markdown

thank you, with this changes download start! this branch must be merged to main and publish new release

@painhardcore

Copy link
Copy Markdown

This works, hell yeah

@FakePepega

FakePepega commented Jul 21, 2025

Copy link
Copy Markdown

Getting
Traceback (most recent call last):
File "kinescope-dl.py", line 4, in
File "", line 1007, in _find_and_load
File "", line 986, in _find_and_load_unlocked
File "", line 680, in load_unlocked
File "PyInstaller\loader\pyimod02_importers.py", line 457, in exec_module
File "kinescope_init
.py", line 2, in
File "", line 1007, in _find_and_load
File "", line 986, in _find_and_load_unlocked
File "", line 680, in _load_unlocked
File "PyInstaller\loader\pyimod02_importers.py", line 457, in exec_module
File "kinescope\downloader.py", line 20, in
File "kinescope\downloader.py", line 45, in VideoDownloader
TypeError: unsupported operand type(s) for |: 'type' and 'ABCMeta'
[PYI-18464:ERROR] Failed to execute script 'kinescope-dl' due to unhandled exception!

Not sure what i missed since i get not errors during building.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants