Repository navigation
Conversation
packem's fix-dynamic-import-extension plugin rewrote every `".ts")` literal that followed an `import(` on the minified line, so the production CLI read `workflows.mjs` and `agents.mjs` and filtered `_generated/` for `.mjs` files: the lazy smoke check never found the deferred workflow and agent modules or the generated loaders. Build the extension from one constant, which the minifier keeps as a variable, until the plugin fix (visulima/packem#450) ships. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
✅ Deploy Preview for lunorash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 46 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Thank you for following the naming conventions! 🙏 |
PR Summary by QodoPreserve TypeScript paths in the production CLI smoke check
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can turn these tips off under Display > Comment parts |
Merging this PR will not alter performance1 warning
Comparing Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #1497 +/- ##
===========================================
+ Coverage 83.97% 88.40% +4.43%
===========================================
Files 2089 249 -1840
Lines 126052 15969 -110083
Branches 32259 4505 -27754
===========================================
- Hits 105855 14118 -91737
+ Misses 19447 1721 -17726
+ Partials 750 130 -620
🚀 New features to boost your workflow:
|
|
Superseded by #1498: @visulima/packem 4.0.4 ships the regex fix (visulima/packem#450), so the source workaround isn't needed. |
Summary
The production build of
@lunora/clishipped a broken lazy smoke check. packem'sfix-dynamic-import-extensionplugin rewrites every".ts")literal that follows animport(on the minified line, and visulima/packem#450 fixes that at the source. As a result:read("workflows.ts")andread("agents.ts")readworkflows.mjsandagents.mjs, which don't exist, so deferred workflow and agent modules were never smoke-loaded.readdirSync(_generated).filter(name => name.endsWith(".ts"))became.endsWith(".mjs"), so no generated loader imports were checked.This PR builds the extension from one constant (
TS_SOURCE_EXTENSION). The minifier keeps it as a variable (X=".ts",), which the regex can't match. The same change coversentry.tsandfunctions.ts, which only survived by chance.A dev-vs-prod scan of every package's built string literals found no other rewritten
.tsliteral onalpha. The@lunora/nuxtoccurrence is fixed in #1487.Test plan
build:prodof@lunora/cli: the shipped chunk hasn("workflows"),n("agents"),endsWith(X),entry${X}andfunctions${X}, and noagents.mjs/workflows.mjslazy-smoke-load.test.ts: 65/65🤖 Generated with Claude Code