Skip to content

build(deps): bump @visulima/packem to 4.0.4 - #1498

Merged
prisis merged 1 commit into
alphafrom
chore/packem-4.0.4
Nov 5, 2026
Merged

prisis merged 1 commit into
alphafrom
chore/packem-4.0.4

Conversation

@prisis

@prisis prisis commented Nov 5, 2026

Copy link
Copy Markdown
Member

Summary

Bumps @visulima/packem 4.0.2 → 4.0.4. 4.0.4 ships the fixed fix-dynamic-import-extension regex (visulima/packem#450), so the production build no longer rewrites unrelated ".ts") literals to .mjs.

This replaces the source workaround in #1497, which I'm closing.

  • Proof: a build:prod of @lunora/cli now ships n("app.ts"), n("workflows.ts"), n("agents.ts"), endsWith(".ts"), "entry.ts" and "functions.ts", with no .mjs rewrites.
  • minimumReleaseAgeExclude: the existing packem lines are updated in place to the 4.0.4 set (packem, packem-rollup, packem-share, rollup-plugin-css, rollup-plugin-dts, css-style-inject), all published 2026-11-05 ~11:12 UTC. Drop them after 2026-11-06.
  • Lockfile side effects: packem's own subtree moves, and rollup 4.67.4 sits alongside 4.65.0. oxc-parser and oxc-transform go 0.155 → 0.157 for every consumer, Nuxt's kit included. Most of the diff is peer-context hashes being recomputed.

Test plan

  • build:packages, then @lunora/cli build:prod: shipped literals checked
  • cli lazy-smoke-load.test.ts 65/65, nuxt 36/36, lint:package-json
  • Template scaffolds (nuxt in particular, because of the oxc bump): left to CI

🤖 Generated with Claude Code

4.0.4 ships the fixed fix-dynamic-import-extension regex
(visulima/packem#450): it no longer rewrites unrelated `".ts")` literals to
`.mjs` on a minified line, which broke the CLI's lazy smoke check
(read("workflows.ts"), endsWith(".ts")). Verified on a production CLI build.

The packem siblings published with it sit in minimumReleaseAgeExclude until
they age past the 24h window. The lockfile also moves oxc-parser and
oxc-transform 0.155 -> 0.157 for every consumer, deduplicated with packem's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@netlify

netlify Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lunorash ready!

Name Link
🔨 Latest commit 7514efb
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6aec7290bf9ad137030a70ed
😎 Deploy Preview https://deploy-preview-1498--lunorash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Nov 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 2

  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml and included by none
  • pnpm-workspace.yaml is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions github-actions Bot added vouch:trusted PR author is a collaborator, a bot or on the VOUCHED list. size:S Size of the change, tests and generated files excluded. labels Nov 5, 2026
@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

PR Summary by Qodo

Bump Packem to 4.0.4 to preserve CLI TypeScript literals

🐞 Bug fix ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Bump Packem to 4.0.4 so production builds stop rewriting unrelated .ts literals to .mjs.
• Refresh the lockfile, including Packem siblings and Oxc versions used beyond the CLI.
• Temporarily exempt the newly published Packem packages from the 24-hour release-age rule.
Diagram

graph TD
  W["Build catalog"] --> L["pnpm lockfile"] --> P["Packem 4.0.4"] --> C(["CLI bundle"])
  L --> O["Oxc 0.157"] --> N(["Nuxt consumers"])
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Retain a CLI source workaround
  • ➕ Avoids the broader transitive dependency changes.
  • ➖ Works around a build-tool defect in application source.
  • ➖ Leaves other Packem-built packages exposed to the same rewrite.

Recommendation: Prefer the upstream Packem fix: the reported production build preserves the affected literals, and a shared dependency update addresses the cause without adding a CLI-specific workaround. Review the wider Oxc resolution changes and remove the release-age exemptions after November 6.

Files changed (2) +1198 / -666

Other (2) +1198 / -666
pnpm-workspace.yamlPin Packem 4.0.4 and temporarily exempt its release set +9/-6

Pin Packem 4.0.4 and temporarily exempt its release set

• Updates the shared build catalog from Packem 4.0.2 to 4.0.4. Replaces the prior Packem release-age exemptions with the newly published Packem, Rollup-plugin, and CSS-style-inject versions, with a November 6 removal note.

pnpm-workspace.yaml

pnpm-lock.yamlResolve the Packem 4.0.4 dependency tree +1189/-660

Resolve the Packem 4.0.4 dependency tree

• Records Packem 4.0.4 and its updated sibling packages, with Rollup 4.67.4 alongside 4.65.0. Updates Oxc parser and transformer resolutions to 0.157.0 and recomputes affected peer-context entries, including Nuxt-related ones.

pnpm-lock.yaml

@qodo-free-for-open-source-projects

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can turn these tips off under Display > Comment parts

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@prisis
prisis merged commit 3ba83d4 into alpha Nov 5, 2026
84 of 86 checks passed
@prisis
prisis deleted the chore/packem-4.0.4 branch November 5, 2026 12:14
@codecov-commenter

codecov-commenter commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.98%. Comparing base (0ade443) to head (7514efb).
⚠️ Report is 3 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #1498      +/-   ##
==========================================
- Coverage   83.99%   83.98%   -0.01%     
==========================================
  Files        2089     2089              
  Lines      126181   126181              
  Branches    31716    32516     +800     
==========================================
- Hits       105982   105979       -3     
- Misses      19454    19456       +2     
- Partials      745      746       +1     

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch was successfully deployed

No deployments
benchmarks — 7514efbe Deployed Nov 5, 2026 by prisis via Benchmarks #7110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🟠 Medium blast radius size:S Size of the change, tests and generated files excluded. vouch:trusted PR author is a collaborator, a bot or on the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants