Skip to content

chore: clear latent jsdoc + no-secrets lint in payment docs - #172

Merged
prisis merged 2 commits into
alphafrom
chore/lint-sweep-payments-docs
Jul 22, 2026
Merged

prisis merged 2 commits into
alphafrom
chore/lint-sweep-payments-docs

Conversation

@prisis

@prisis prisis commented Jul 22, 2026 •

Copy link
Copy Markdown
Member

Three eslint errors sit latent on alpha in payment-feature doc comments — they only surface when a PR makes @lunora/codegen or @lunora/do "affected" (lint:affected never re-lints them otherwise), which currently blocks unrelated PRs (#165, #166) via the PR-merge lint.

  • codegen/src/discover-feature-usage.ts + do/src/introspect.ts — jsdoc/lines-before-block: add the required blank line before a multi-line JSDoc block.
  • codegen/src/discover-feature-usage.ts + run-codegen.ts — no-secrets/no-secrets false-positives on the backticked identifiers verifyStandardWebhook and StudioFeatureSignals.hasPaymentTables in prose → reword to plain words.

Comment-only; no behavior change. Merging this greens the affected-lint for any PR that touches those packages.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Clarified internal documentation for payment-related feature gating and table-detection signals.
    • Improved spacing and readability in feature flag documentation.
    • No user-facing functionality or behavior changed.

Three latent eslint errors in payment-feature doc comments on alpha that only
surface when a PR makes @lunora/codegen or @lunora/do "affected" (they sit
unchecked otherwise), blocking unrelated PRs:

- codegen/discover-feature-usage.ts + do/introspect.ts: `jsdoc/lines-before-block`
  — add the required blank line before a multi-line JSDoc block.
- codegen/discover-feature-usage.ts + run-codegen.ts: `no-secrets/no-secrets`
  false-positives on the backticked identifiers `verifyStandardWebhook` and
  `StudioFeatureSignals.hasPaymentTables` in prose — reword to plain words; no
  behavior change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0197KjhmBDB3PXAc6TXiPqZ9
@netlify

netlify Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lunorash ready!

Name Link
🔨 Latest commit e4a11f2
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a60ebb84756380008992134
😎 Deploy Preview https://deploy-preview-172--lunorash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • packages/vite/__tests__/studio-plugin.test.ts is excluded by !**/__tests__/**, !**/*.test.ts and included by packages/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3b7c9f1b-54b2-4094-a58b-2c343412120c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Updated comments describing payment table-based feature gating and adjusted spacing in Studio feature documentation. No executable logic, public declarations, or emitted outputs changed.

Changes

Feature gating documentation

Layer / File(s) Summary
Align feature gating documentation
packages/codegen/src/discover-feature-usage.ts, packages/codegen/src/run-codegen.ts, packages/do/src/introspect.ts
Payment gating comments were revised, and a blank line was added to the StudioFeaturesResult documentation block without changing runtime behavior or type fields.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • anolilab/lunora#171: Introduces the related payment-table gating behavior and hasPaymentTables signal.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the summary but omits required template sections like linked issues, test plan, checklist, notes, and CLA. Add the missing template sections, especially linked issues, test plan, checklist items, notes for reviewers, and the CLA statement.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and matches the main change: fixing lint issues in payment docs comments.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/lint-sweep-payments-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

Same latent bug as the doc lint: the studio-plugin ETag test used
`expect.hasAssertions()` but makes zero assertions on the unbuilt-studio (501)
path taken in the affected-test CI env, so it fails whenever a PR makes
@lunora/vite affected. Replace with an unconditional
`expect([200, 501]).toContain(statusCode)`.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0197KjhmBDB3PXAc6TXiPqZ9
@prisis
prisis enabled auto-merge July 22, 2026 16:11
@prisis
prisis disabled auto-merge July 22, 2026 16:17
@prisis
prisis merged commit d4f746c into alpha Jul 22, 2026
37 of 39 checks passed
@prisis
prisis deleted the chore/lint-sweep-payments-docs branch July 22, 2026 16:17
@codspeed

codspeed Bot commented Jul 22, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 10.1%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 100 untouched benchmarks
⏩ 60 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ 1 shard × 1000 rows (single round-trip) 2.9 ms 3.2 ms -10.1%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing chore/lint-sweep-payments-docs (e4a11f2) with alpha (948d27f)2

Open in CodSpeed

Footnotes

  1. 60 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on alpha (31411d3) during the generation of this report, so 948d27f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

prisis added a commit that referenced this pull request Jul 22, 2026
…st (#178)

#172 replaced `expect.hasAssertions()` with an unconditional
`expect([200, 501])` to survive the unbuilt-studio (501) path, but that trips
`vitest/prefer-expect-assertions` (fails under --max-warnings=0 whenever a PR
makes @lunora/vite affected). Restore `expect.hasAssertions()` as the first
expression — now safe because the unconditional assertion guarantees ≥1 on
every path — satisfying both the rule and the 501 environment.


Claude-Session: https://claude.ai/code/session_0197KjhmBDB3PXAc6TXiPqZ9

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 9, 2026

This branch was previously deployed

1 inactive deployment
benchmarks — e4a11f2d Deployed Jul 22, 2026 by prisis via Benchmarks #866
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant