Repository navigation
chore: clear latent jsdoc + no-secrets lint in payment docs - #172
Conversation
Three latent eslint errors in payment-feature doc comments on alpha that only surface when a PR makes @lunora/codegen or @lunora/do "affected" (they sit unchecked otherwise), blocking unrelated PRs: - codegen/discover-feature-usage.ts + do/introspect.ts: `jsdoc/lines-before-block` — add the required blank line before a multi-line JSDoc block. - codegen/discover-feature-usage.ts + run-codegen.ts: `no-secrets/no-secrets` false-positives on the backticked identifiers `verifyStandardWebhook` and `StudioFeatureSignals.hasPaymentTables` in prose — reword to plain words; no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0197KjhmBDB3PXAc6TXiPqZ9
✅ Deploy Preview for lunorash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughUpdated comments describing payment table-based feature gating and adjusted spacing in Studio feature documentation. No executable logic, public declarations, or emitted outputs changed. ChangesFeature gating documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for following the naming conventions! 🙏 |
|
Thank you for confirming the Contributor License Agreement! 🙏 |
Same latent bug as the doc lint: the studio-plugin ETag test used `expect.hasAssertions()` but makes zero assertions on the unbuilt-studio (501) path taken in the affected-test CI env, so it fails whenever a PR makes @lunora/vite affected. Replace with an unconditional `expect([200, 501]).toContain(statusCode)`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0197KjhmBDB3PXAc6TXiPqZ9
Merging this PR will degrade performance by 10.1%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | 1 shard × 1000 rows (single round-trip) |
2.9 ms | 3.2 ms | -10.1% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing chore/lint-sweep-payments-docs (e4a11f2) with alpha (948d27f)2
Footnotes
-
60 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
alpha(31411d3) during the generation of this report, so 948d27f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
…st (#178) #172 replaced `expect.hasAssertions()` with an unconditional `expect([200, 501])` to survive the unbuilt-studio (501) path, but that trips `vitest/prefer-expect-assertions` (fails under --max-warnings=0 whenever a PR makes @lunora/vite affected). Restore `expect.hasAssertions()` as the first expression — now safe because the unconditional assertion guarantees ≥1 on every path — satisfying both the rule and the 501 environment. Claude-Session: https://claude.ai/code/session_0197KjhmBDB3PXAc6TXiPqZ9 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Three eslint errors sit latent on
alphain payment-feature doc comments — they only surface when a PR makes@lunora/codegenor@lunora/do"affected" (lint:affectednever re-lints them otherwise), which currently blocks unrelated PRs (#165, #166) via the PR-merge lint.codegen/src/discover-feature-usage.ts+do/src/introspect.ts—jsdoc/lines-before-block: add the required blank line before a multi-line JSDoc block.codegen/src/discover-feature-usage.ts+run-codegen.ts—no-secrets/no-secretsfalse-positives on the backticked identifiersverifyStandardWebhookandStudioFeatureSignals.hasPaymentTablesin prose → reword to plain words.Comment-only; no behavior change. Merging this greens the affected-lint for any PR that touches those packages.
🤖 Generated with Claude Code
Summary by CodeRabbit