Skip to content

docs(plans): correct stale statuses in the plan index - #366

Merged
prisis merged 4 commits into
alphafrom
docs/plans-readme-truth
Aug 8, 2026
Merged

prisis merged 4 commits into
alphafrom
docs/plans-readme-truth

Conversation

@prisis

@prisis prisis commented Aug 8, 2026

Copy link
Copy Markdown
Member

Why

plans/README.md is the plan index, and its status columns had gone stale in ways that actively mislead. Three separate classes of error, all verified against live code before editing.

Wave 13 read TODO for work that shipped a year of commits ago

All 24 rows of the Wave 13 table (plans 138–162) were marked TODO. Twenty-two of them shipped on 2026-07-19 in a single squash, a2d60e529 (#146, 161 files). The file already contained its own contradiction — an "Execution status (2026-07-18)" table sixty lines below marks every one of them ✅ DONE.

Each row now points at that table. Two exceptions, both verified against live code:

  • 160 (voice/agent consolidation) genuinely did not ship and stays deferred — five copies of voice-audio.ts (~327 lines each) and five of use-voice-agent (~490 each) are still live across react/vue/solid/svelte/angular.
  • 162 is partial by design: leader demotion and offline-queue FIFO shipped, but CLIENT-01's subscribe relay is design-only — no follower→leader message exists in the wire union.

143's Pkg column also moves from do to shard-engine, where that code now lives.

Worth knowing for anyone reading that table: no plan file was ever written for 138–159/161. The absence of plans/<n>-*.md says nothing about whether the work shipped.

Plan 265 read BLOCKED — DO NOT MERGE when it had actually landed

The scariest of the three, because the row said "blocked" when the truth was "shipped broken". ab0afaf00 (#338) shipped encodeDocJson/decodeDocJson without touching serialize-sql.ts or estimate-bytes.ts, so the review's findings became live defects on alpha rather than warnings about a branch.

The row now states that, restates the two findings that are still live, corrects one that was wrong (estimateBytes does not throw or charge the 32 MiB cap — it returns undefined and transaction-headroom.ts raises BAD_REQUEST, so with plan 270 landed a bigint insert fails loudly at the door), and closes one that is a documented decision from plan 300 rather than an outstanding blocker. It also carries the backfill requirement, which is the part that must not get lost: patch/replace re-project on write, but a row nobody rewrites stays invisible to amount queries.

Smaller corrections

New executor note: never measure a baseline on a cold tree

Added to the carried-forward notes, because it invalidated a plan's sizing. Type-aware ESLint reports a flood of phantom no-unsafe-* findings when a workspace dependency's dist/ is missing: @lunora/svelte reads 455 cold and 24 after build:packages; @lunora/db reads 109 cold and 38. A plan sized off a cold number is sized off nothing.

Verification

Prettier-clean. Every status change is backed by a file:line in live code or a commit; the seven rows still reading TODO (033, 037, 135, 168, 169, 303, 306) were each confirmed genuinely open.

Docs only — no code, no tests, no public surface.

🤖 Generated with Claude Code

https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP

prisis and others added 3 commits August 8, 2026 13:58
The Wave 13 table listed all 24 rows as TODO. 22 of them shipped on
2026-07-19 in the squash a2d60e5 (#146) — the file already contained
the contradicting record in its own execution-status table 60 lines
below, which is now what the rows point at. 160 stays deferred (five
copies of voice-audio.ts are still live) and 162 is partial by design
(its relay half was answered as a design doc). 143's Pkg column moves
from do to shard-engine, where that code now lives.

Plan 265 read BLOCKED - DO NOT MERGE. It is not blocked, it landed:
ab0afaf (#338) shipped encodeDocJson/decodeDocJson without touching
serialize-sql.ts or estimate-bytes.ts, so the review's findings are
live defects on alpha rather than warnings about a branch. Two of them
are restated as such, one is corrected (estimateBytes does not throw or
charge the 32 MiB cap - transaction-headroom raises BAD_REQUEST, so a
bigint insert fails loudly) and one is closed (the introspect item is a
documented decision from plan 300).

Plan 306 had no row anywhere in the file; it gets one. The remaining
files list named 235 and 248, deleted by the same commit that wrote the
list, and omitted five files that exist. Three wave preambles asserted
none executed yet above tables of shipped rows.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
Phases 2-5 had already shipped as a4c6522 (#343); the remaining work
is on two branches whose merge order matters, because the phase-10
check fails on a stale allowlist entry as well as a missing one.

Re-measured counts differ from the plan's, and the reason is worth
carrying: a cold tree reports 455 eslint findings for svelte against 24
after build:packages, and 109 against 38 for db. The extra ones are
no-unsafe-* cascades from a missing dependency dist.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
The row now carries the design decision (project to a SQL-comparable
scalar, park the exact original) and the reason the cheaper fix was
rejected: a tagged array is still text to SQLite, so equality would
have worked while ranges, ORDER BY and SUM stayed silently wrong.

The backfill is the part that must not get lost. Rows written between
ab0afaf and the fix hold the bigint tagged in place; patch and
replace re-project on write, but a row nobody rewrites stays invisible
to amount queries - completed payment sessions being the exact shape
that is never touched again.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
@coderabbitai

coderabbitai Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • plans/README.md is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ba833143-9f24-4ddd-8853-faad83922205

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@netlify

netlify Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lunorash ready!

Name Link
🔨 Latest commit 21e13b4
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a772799aa29e200085c8c42
😎 Deploy Preview https://deploy-preview-366--lunorash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@prisis
prisis merged commit bd5216d into alpha Aug 8, 2026
29 of 30 checks passed
@prisis
prisis deleted the docs/plans-readme-truth branch August 8, 2026 13:05
prisis added a commit that referenced this pull request Aug 8, 2026
* docs(plans): record the 265 encoding decision

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP

* fix(plans): restore prettier formatting in the plan index

The table-row rewrites in #366 left the column padding ragged, and the
check that should have caught it was run from the main checkout against
a path under .worktrees/, which prettier ignores — so it checked zero
files and reported success.

prettier --check . is a required lint job, and CI runs it against
refs/pull/N/merge, so this failed every open PR rather than just the one
that introduced it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant