Repository navigation
docs(plans): correct stale statuses in the plan index - #366
Conversation
The Wave 13 table listed all 24 rows as TODO. 22 of them shipped on 2026-07-19 in the squash a2d60e5 (#146) — the file already contained the contradicting record in its own execution-status table 60 lines below, which is now what the rows point at. 160 stays deferred (five copies of voice-audio.ts are still live) and 162 is partial by design (its relay half was answered as a design doc). 143's Pkg column moves from do to shard-engine, where that code now lives. Plan 265 read BLOCKED - DO NOT MERGE. It is not blocked, it landed: ab0afaf (#338) shipped encodeDocJson/decodeDocJson without touching serialize-sql.ts or estimate-bytes.ts, so the review's findings are live defects on alpha rather than warnings about a branch. Two of them are restated as such, one is corrected (estimateBytes does not throw or charge the 32 MiB cap - transaction-headroom raises BAD_REQUEST, so a bigint insert fails loudly) and one is closed (the introspect item is a documented decision from plan 300). Plan 306 had no row anywhere in the file; it gets one. The remaining files list named 235 and 248, deleted by the same commit that wrote the list, and omitted five files that exist. Three wave preambles asserted none executed yet above tables of shipped rows. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
Phases 2-5 had already shipped as a4c6522 (#343); the remaining work is on two branches whose merge order matters, because the phase-10 check fails on a stale allowlist entry as well as a missing one. Re-measured counts differ from the plan's, and the reason is worth carrying: a cold tree reports 455 eslint findings for svelte against 24 after build:packages, and 109 against 38 for db. The extra ones are no-unsafe-* cascades from a missing dependency dist. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
The row now carries the design decision (project to a SQL-comparable scalar, park the exact original) and the reason the cheaper fix was rejected: a tagged array is still text to SQLite, so equality would have worked while ranges, ORDER BY and SUM stayed silently wrong. The backfill is the part that must not get lost. Rows written between ab0afaf and the fix hold the bigint tagged in place; patch and replace re-project on write, but a row nobody rewrites stays invisible to amount queries - completed payment sessions being the exact shape that is never touched again. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
|
Thank you for following the naming conventions! 🙏 |
|
Thank you for confirming the Contributor License Agreement! 🙏 |
✅ Deploy Preview for lunorash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
* docs(plans): record the 265 encoding decision Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP * fix(plans): restore prettier formatting in the plan index The table-row rewrites in #366 left the column padding ragged, and the check that should have caught it was run from the main checkout against a path under .worktrees/, which prettier ignores — so it checked zero files and reported success. prettier --check . is a required lint job, and CI runs it against refs/pull/N/merge, so this failed every open PR rather than just the one that introduced it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Why
plans/README.mdis the plan index, and its status columns had gone stale in ways that actively mislead. Three separate classes of error, all verified against live code before editing.Wave 13 read
TODOfor work that shipped a year of commits agoAll 24 rows of the Wave 13 table (plans 138–162) were marked
TODO. Twenty-two of them shipped on 2026-07-19 in a single squash,a2d60e529(#146, 161 files). The file already contained its own contradiction — an "Execution status (2026-07-18)" table sixty lines below marks every one of them ✅ DONE.Each row now points at that table. Two exceptions, both verified against live code:
voice-audio.ts(~327 lines each) and five ofuse-voice-agent(~490 each) are still live across react/vue/solid/svelte/angular.143's Pkg column also moves fromdotoshard-engine, where that code now lives.Worth knowing for anyone reading that table: no plan file was ever written for 138–159/161. The absence of
plans/<n>-*.mdsays nothing about whether the work shipped.Plan 265 read
BLOCKED — DO NOT MERGEwhen it had actually landedThe scariest of the three, because the row said "blocked" when the truth was "shipped broken".
ab0afaf00(#338) shippedencodeDocJson/decodeDocJsonwithout touchingserialize-sql.tsorestimate-bytes.ts, so the review's findings became live defects onalpharather than warnings about a branch.The row now states that, restates the two findings that are still live, corrects one that was wrong (
estimateBytesdoes not throw or charge the 32 MiB cap — it returnsundefinedandtransaction-headroom.tsraisesBAD_REQUEST, so with plan 270 landed a bigint insert fails loudly at the door), and closes one that is a documented decision from plan 300 rather than an outstanding blocker. It also carries the backfill requirement, which is the part that must not get lost:patch/replacere-project on write, but a row nobody rewrites stays invisible to amount queries.Smaller corrections
7c3d3f42e, the same commit that wrote the list) and omitted five that do (234, 265, 302, 306,execution-status.md). Re-verified againstls plans/: every file listed exists, and every file in the directory is listed.a4c6522eb(fix: clear the hidden lint backlog in 4 packages, then un-skip them (plan 302 phases 2–5) #343) — the plan's own status line was stale too — with the rest on fix(svelte): clear the hidden lint backlog, then un-skip the gate #363 and fix(repo): un-skip three lint gates and guard against the shape #364, including the merge-order dependency between them.New executor note: never measure a baseline on a cold tree
Added to the carried-forward notes, because it invalidated a plan's sizing. Type-aware ESLint reports a flood of phantom
no-unsafe-*findings when a workspace dependency'sdist/is missing:@lunora/sveltereads 455 cold and 24 afterbuild:packages;@lunora/dbreads 109 cold and 38. A plan sized off a cold number is sized off nothing.Verification
Prettier-clean. Every status change is backed by a file:line in live code or a commit; the seven rows still reading
TODO(033, 037, 135, 168, 169, 303, 306) were each confirmed genuinely open.Docs only — no code, no tests, no public surface.
🤖 Generated with Claude Code
https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP