Repository navigation
fix(repo): empty the stale project.json allowlist - #368
Conversation
The svelte cleanup (#363) and the guard that allowlisted it (#364) both landed, so the entry now describes an already-clean project. The check fails on a stale entry by design, which is what makes an allowlist unable to outlive its fix — so alpha went red the moment the second of the two merged, and every open PR inherits it through refs/pull/N/merge. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
✅ Deploy Preview for lunorash ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reached
Next review available in: 34 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for following the naming conventions! 🙏 |
|
Thank you for confirming the Contributor License Agreement! 🙏 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What
alphais red onLint (eslint)→Check project.json target shapes, and every open PR inherits it throughrefs/pull/N/merge.This empties the allowlist. One line.
Why it fired
The check fails on a stale entry as well as a missing one — deliberately, because that is what stops an allowlist decaying into a permanent exemption. #364 added the guard with
packages/sveltelisted as still-unmigrated; #363 madepackages/svelteclean. Each was correct alone, and the pair was fine in either order until both landed. The second merge turned the debt marker into a lie and the check said so.This was called out as a merge-order dependency in both PR bodies — whichever landed second had to empty the map — and was not done at merge time. The mechanism is working as designed; this is the follow-through it was waiting for.
Verification
Against
origin/alphabefore the change:node scripts/check-project-json-targets.js→ exit 1 with the message above. After:✅ 72 of 72 project.json files declare no silently-skipped target., exit 0. Prettier clean.The guard keeps its teeth — the stale-entry branch is untouched, so the next allowlist entry still cannot outlive its fix.
🤖 Generated with Claude Code
https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP