Skip to content

fix(repo): empty the stale project.json allowlist - #368

Merged
prisis merged 1 commit into
alphafrom
fix/302-stale-allowance
Aug 8, 2026
Merged

prisis merged 1 commit into
alphafrom
fix/302-stale-allowance

Conversation

@prisis

@prisis prisis commented Aug 8, 2026

Copy link
Copy Markdown
Member

What

alpha is red on Lint (eslint) → Check project.json target shapes, and every open PR inherits it through refs/pull/N/merge.

❌ 1 entr(y/ies) in KNOWN_UNMIGRATED describe an already-clean project:
   packages/svelte/project.json — remove it from scripts/check-project-json-targets.js

This empties the allowlist. One line.

Why it fired

The check fails on a stale entry as well as a missing one — deliberately, because that is what stops an allowlist decaying into a permanent exemption. #364 added the guard with packages/svelte listed as still-unmigrated; #363 made packages/svelte clean. Each was correct alone, and the pair was fine in either order until both landed. The second merge turned the debt marker into a lie and the check said so.

This was called out as a merge-order dependency in both PR bodies — whichever landed second had to empty the map — and was not done at merge time. The mechanism is working as designed; this is the follow-through it was waiting for.

Verification

Against origin/alpha before the change: node scripts/check-project-json-targets.js → exit 1 with the message above. After: ✅ 72 of 72 project.json files declare no silently-skipped target., exit 0. Prettier clean.

The guard keeps its teeth — the stale-entry branch is untouched, so the next allowlist entry still cannot outlive its fix.

🤖 Generated with Claude Code

https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP

The svelte cleanup (#363) and the guard that allowlisted it (#364) both
landed, so the entry now describes an already-clean project. The check
fails on a stale entry by design, which is what makes an allowlist
unable to outlive its fix — so alpha went red the moment the second of
the two merged, and every open PR inherits it through refs/pull/N/merge.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011sk9BLaUZDkPVAZ1sKhuDP
@netlify

netlify Bot commented Aug 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for lunorash ready!

Name Link
🔨 Latest commit 64bcfb8
🔍 Latest deploy log https://app.netlify.com/projects/lunorash/deploys/6a773b4e9caabf00088c70c2
😎 Deploy Preview https://deploy-preview-368--lunorash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@prisis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dc99a9c2-7ad1-44ea-9b95-7c7c0680248f

📥 Commits

Reviewing files that changed from the base of the PR and between c2f2719 and 64bcfb8.

📒 Files selected for processing (1)
  • scripts/check-project-json-targets.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for confirming the Contributor License Agreement! 🙏

@prisis
prisis merged commit 4361cbc into alpha Aug 8, 2026
31 checks passed
@prisis
prisis deleted the fix/302-stale-allowance branch August 8, 2026 14:29
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using our GitHub Discussions tab for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant