Skip to content

fix(core): treat empty apiKey as unset - #49215

Closed
kvnloo wants to merge 1 commit into
anomalyco:devfrom
kvnloo:fix/empty-apikey-as-unset-42790
Closed

kvnloo wants to merge 1 commit into
anomalyco:devfrom
kvnloo:fix/empty-apikey-as-unset-42790

Conversation

@kvnloo

@kvnloo kvnloo commented Sep 15, 2026

Copy link
Copy Markdown

Fixes #42790

Empty apiKey was treated as a configured credential: catalog available() enabled the provider for any string (including ""), and the session runner mapped "" through Auth.value(""), which fails auth apply instead of using Auth.none like an omitted key.

Only non-empty apiKey strings count as enablement/credentials now.

Test plan

  • bun test test/catalog.test.ts test/session-runner-model.test.ts -t "missing and empty apiKey|empty configured apiKey|omitted apiKey" (fail on tip → pass on branch)
  • Full catalog.test.ts + session-runner-model.test.ts (29 pass)

Empty string apiKey must not enable a provider or suppress Auth.none.
Fixes anomalyco#42790.
@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Sep 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Sep 15, 2026
@github-actions github-actions Bot closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configured credentialless providers require an empty API key

1 participant