Conversation
Empty string apiKey must not enable a provider or suppress Auth.none. Fixes anomalyco#42790.
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42790
Empty
apiKeywas treated as a configured credential: catalogavailable()enabled the provider for any string (including""), and the session runner mapped""throughAuth.value(""), which fails auth apply instead of usingAuth.nonelike an omitted key.Only non-empty
apiKeystrings count as enablement/credentials now.Test plan
bun test test/catalog.test.ts test/session-runner-model.test.ts -t "missing and empty apiKey|empty configured apiKey|omitted apiKey"(fail on tip → pass on branch)catalog.test.ts+session-runner-model.test.ts(29 pass)