fix: add error handling to RPC system to prevent crashes on session abort #7939
+39
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a crash that occurs when aborting a session with double-escape. The app would crash with "Unexpected end of JSON input" error.
Fixes #7946
An example of error
Changes:
rpc.errormessages in client to reject promises properly.catch()tosession.abortcall to prevent unhandled rejections/session/:sessionID/promptinstead of a streaming response to avoid empty bodies on abort/session/:sessionID/prompt_asyncwith a 204 no-content response and server-side error loggingHow did you verify your code works?
Note: I have not rerun the flow after the latest server response adjustments in this environment.