Repository navigation
fix(opencode): prevent RPC hangs on disconnected stderr - #43
Merged
Merged
Conversation
This was referenced Oct 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
rift.createintermittently hung in OpenCode's background service even though the checkout was created. Restarting the service made one test succeed, but the hang returned on later calls.The RPC bridge pipes hook output into
process.stderr. When the host's stderr reader has disconnected, repeated RPC calls can leave the child's stderr stream paused. In an isolated reproduction, Rift exited successfully and stdout ended, but stderr never ended, so theclosehandler never resolved the tool call. Resuming stderr allowedcloseto fire.Fix
Drain child stderr directly and retain its last
8 * 1024bytes, including that diagnostic tail when the process exits unsuccessfully. This removes the dependency on the host's stderr while keeping useful failure output.This follows OpenCode's own service contender, which consumes child stderr into an 8 KB tail, and its process runner, which drains stdout and stderr concurrently with waiting for exit.
Regression coverage runs three RPC calls in a Bun host whose stderr reader is disconnected and checks bounded diagnostics on failure. Hook output is no longer forwarded live to the host's stderr; structured RPC responses remain unchanged.