Repository navigation
fix(opencode): report committed hook failures in tool results - #49
Merged
Merged
Conversation
nexxeln
added this pull request to stack #51
October 5, 2026 07:51
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack: #49 ← #50
Why the change
When a postcreate or postremove hook failed after Rift had already created or removed the workspace,
rift.createandrift.removestill told the agent everything worked, because the warning only went to the server's stderr.Special things to note
warningfield and add aWarning:line to their text. The workspace still counts as created or removed, which matches what's on disk.setupwith a fake host and a fakerift. I haven't checked this against a running OpenCode yet.Change outline
The strategy reports committed hook failures through its
warningcallback while the host's worktree call is still running. Each tool call adds a listener for the length of that call, then keeps only the warning for its own directory. Concurrent calls and UI-driven operations can't leak into each other's results.What the agent sees after a failing
pnpm installpostcreate hook: