CHORE: adding grpc message#2232
Conversation
svandenb-dev
requested review from
SMoraisAnsys,
Samuelopez-ansys and
maxcapodi78
as code owners
github-actions
Bot
added
maintenance
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Don't you think it would be a good idea to wait a bit more to switch for gRPC ? Wouldn't notify users about the incoming release be a better way and then proceed with the change a bit later ?
| import warnings | ||
|
|
||
| from pyedb.generic.grpc_warnings import GRPC_BETA_WARNING, GRPC_NOT_SUPPORTED_WARNING | ||
| from pyedb.generic.grpc_warnings import GRPC_NOT_SUPPORTED_WARNING |
There was a problem hiding this comment.
I think there is no need to keep the warning in the grpc_warnings module either, right ?
| GRPC_DEFAULT_MESSAGE = ( | ||
| "gRPC is now the default mode starting with Ansys release 26.1.2 (June 10th). " | ||
| "gRPC introduces Fast Mode, which significantly increases speed. " | ||
| "Make sure you are using the latest PyEDB and AEDT versions." | ||
| ) |
There was a problem hiding this comment.
I think this message should be reworked, it tastes strange (very subjective here).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2232 +/- ##
==========================================
+ Coverage 70.20% 75.67% +5.46%
==========================================
Files 261 266 +5
Lines 42416 45497 +3081
==========================================
+ Hits 29779 34430 +4651
+ Misses 12637 11067 -1570 🚀 New features to boost your workflow:
|
5 participants
This PR is adding grpc message and adjusting CI timeout due to tests increase.