Skip to content

CHORE: adding grpc message #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svandenb-dev merged 10 commits into from
Jun 4, 2026
Merged

CHORE: adding grpc message #2232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8f77388
fixed
svandenb-dev Jun 3, 2026
e0d2e79
chore: adding changelog file 2232.maintenance.md [dependabot-skip]
pyansys-ci-bot Jun 3, 2026
8f6f838
fixed
svandenb-dev Jun 4, 2026
4b1161b
Merge remote-tracking branch 'origin/grpc-message' into grpc-message
svandenb-dev Jun 4, 2026
fbbac0c
Merge branch 'main' into grpc-message
svandenb-dev Jun 4, 2026
51b7d31
fixed
svandenb-dev Jun 4, 2026
14fed2a
fixed
svandenb-dev Jun 4, 2026
cbd1136
Merge remote-tracking branch 'origin/grpc-message' into grpc-message
svandenb-dev Jun 4, 2026
ff47da6
message adjusted
svandenb-dev Jun 4, 2026
bcab104
message adjusted
svandenb-dev Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 40
timeout_minutes: 60
command: |
.venv\Scripts\activate
pytest tests/system --cov=pyedb --color=yes -ra
Expand Down Expand Up @@ -306,7 +306,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 120
timeout_minutes: 180
command: |
. .venv\Scripts\Activate.ps1
pytest tests/system -vvv --cov=pyedb --color=yes -ra
Expand Down Expand Up @@ -375,7 +375,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 40
timeout_minutes: 60
command: |
source .venv/bin/activate
pytest tests/system -vvv --cov=pyedb --color=yes -ra
Expand Down Expand Up @@ -444,7 +444,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 120
timeout_minutes: 180
command: |
source .venv/bin/activate
pytest tests/system -vvv --cov=pyedb --color=yes -ra
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/ci-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 120
timeout_minutes: 180
command: |
source .venv/bin/activate
pytest tests/system -vvv --cov
Expand Down Expand Up @@ -448,7 +448,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 120
timeout_minutes: 180
command: |
source .venv/bin/activate
pytest tests/system -vvv --cov
Expand Down Expand Up @@ -527,7 +527,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 120
timeout_minutes: 180
command: |
source .venv/bin/activate
pytest -v external/pyaedt/tests/system/layout/test_3dlayout_edb.py
Expand All @@ -545,7 +545,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 120
timeout_minutes: 180
command: |
source .venv/bin/activate
pytest -v external/pyaedt/tests/system/solvers/test_analyze.py
Expand All @@ -558,7 +558,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 120
timeout_minutes: 180
command: |
source .venv/bin/activate
pytest -v external/pyaedt/tests/system/extensions/test_cutout.py
Expand Down Expand Up @@ -635,7 +635,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 120
timeout_minutes: 180
command: |

source .venv/bin/activate
Expand All @@ -654,7 +654,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 120
timeout_minutes: 180
command: |
source .venv/bin/activate
pytest -v external/pyaedt/tests/system/solvers/test_analyze.py
Expand All @@ -667,7 +667,7 @@ jobs:
with:
max_attempts: 3
retry_on: error
timeout_minutes: 120
timeout_minutes: 180
command: |
source .venv/bin/activate
pytest -v external/pyaedt/tests/system/extensions/test_cutout.py
Expand Down
1 change: 1 addition & 0 deletions doc/changelog.d/2232.maintenance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Adding grpc message
6 changes: 3 additions & 3 deletions src/pyedb/dotnet/database/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,12 +1155,12 @@ def deactivate_rlc_component(self, component=None, create_circuit_port=False, pe
Examples
--------
>>> from pyedb import Edb
>>> edb_file = r"C:\my_edb_file.aedb"
>>> edb_file = r"C:\\my_edb_file.aedb"
>>> edb = Edb(edb_file)
>>> for cmp in list(edb.components.instances.keys()):
>>> edb.components.deactivate_rlc_component(component=cmp, create_circuit_port=False)
>>> edb.save_edb()
>>> edb.close_edb()
>>> edb.save()
>>> edb.close()
"""
if not component:
return False
Expand Down
12 changes: 4 additions & 8 deletions src/pyedb/generic/design_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,12 @@
from typing import TYPE_CHECKING, Any, Literal, overload
import warnings

from pyedb.generic.grpc_warnings import GRPC_BETA_WARNING, GRPC_NOT_SUPPORTED_WARNING
from pyedb.generic.grpc_warnings import GRPC_NOT_SUPPORTED_WARNING
Comment thread
svandenb-dev marked this conversation as resolved.
from pyedb.generic.settings import settings
from pyedb.misc.decorators import deprecate_argument_name

DEFAULT_GRPC_VERSION = 2026.1
GRPC_DEFAULT_MESSAGE = "gRPC mode enabled."

if TYPE_CHECKING:
from pyedb.dotnet.edb import Edb as EdbDotnet
Expand Down Expand Up @@ -371,8 +372,8 @@ def Edb(
settings.is_grpc = grpc

if grpc:
if 2025.2 <= float(settings.specified_version) <= 2027.1:
warnings.warn(GRPC_BETA_WARNING, UserWarning)
if float(settings.specified_version) >= 2025.2:
settings.logger.info(GRPC_DEFAULT_MESSAGE)
from pyedb.grpc.edb import Edb

return Edb(
Expand All @@ -396,11 +397,6 @@ def Edb(
f"Please use version 2025.2 or later."
)

raise RuntimeError(
f"gRPC backend selection is only supported for AEDT versions between 2025.2 and 2027.1. "
f"Got {settings.specified_version}."
)

else:
from pyedb.dotnet.edb import Edb

Expand Down
2 changes: 1 addition & 1 deletion src/pyedb/grpc/database/components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2165,7 +2165,7 @@ def deactivate_rlc_component(
Examples
--------
>>> from pyedb import Edb
>>> edb_file = r"C:\my_edb_file.aedb"
>>> edb_file = r"C:\\my_edb_file.aedb"
>>> edb = Edb(edb_file)
>>> for cmp in list(edb.components.instances.keys()):
>>> edb.components.deactivate_rlc_component(component=cmp, create_circuit_port=False)
Expand Down
2 changes: 1 addition & 1 deletion src/pyedb/workflows/utilities/siwave_log_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
Basic usage for parsing a SIwave log file:

>>> from pyedb.workflows.utilities.siwave_log_parser import SiwaveLogParser
>>> parser = SiwaveLogParser(r"C:\path\to\siwave.log")
>>> parser = SiwaveLogParser(r"C:\\path\\to\\siwave.log")
>>> log = parser.parse()
>>> log.summary()
>>> log.to_json("siwave.json")
Expand Down
24 changes: 0 additions & 24 deletions tests/unit/test_design_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,17 +85,6 @@ def dotnet_edb(**kwargs):
monkeypatch.setitem(sys.modules, "pyedb.dotnet.edb", dotnet_module)


@pytest.mark.skipif(not config["use_grpc"], reason="Applies only for grpc.")
Comment thread
svandenb-dev marked this conversation as resolved.
def test_edb_defaults_to_grpc_for_2026_1_and_later(restore_settings_state, fake_backends):
with pytest.warns(UserWarning):
backend, kwargs = design_types.Edb(version="2026.1")

assert backend == "grpc"
assert kwargs["version"] == "2026.1"
assert settings.specified_version == "2026.1"
assert settings.is_grpc is True


def test_edb_defaults_to_dotnet_before_2026_1(restore_settings_state, fake_backends):
backend, kwargs = design_types.Edb(version="2025.2")

Expand All @@ -106,19 +95,6 @@ def test_edb_defaults_to_dotnet_before_2026_1(restore_settings_state, fake_backe
assert settings.is_in_memory is False


def test_edb_uses_resolved_default_version_for_backend_selection(restore_settings_state, fake_backends):
settings.specified_version = None
settings.LATEST_VERSION = "2026.1"

with pytest.warns(UserWarning):
backend, kwargs = design_types.Edb()

assert backend == "grpc"
assert kwargs["version"] is None
assert settings.specified_version == "2026.1"
assert settings.is_grpc is True


def test_edb_respects_explicit_grpc_override(restore_settings_state, fake_backends):
backend, kwargs = design_types.Edb(version="2026.1", grpc=False, in_memory=True)

Expand Down
Loading