Repository navigation
Share play invitations reach the Notification Center - #261
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was missing on main
A two-account run showed a guest on Notifications or an empty Home never saw a share play invitation; it only appeared on the party page, and the first invitation expired unseen.
model.toast), with no entry in the Notification Center, unlike a party invitation. Missing.What changed
Act::JoinShare(id). The invitation is announced like a party invitation (toast with the invite cue, entry of kind Invitation, text "Lumen invites you to share play"). With the Friends panel open only the entry is kept.SharePlayCommand::Answeras the Accept row on the party page and removes the entry. When the invitation is answered or has run out the entry has no button (Dismiss stays). The unread entry lights the bell badge, also on an empty library.Scenes
notifications-share(Notification Center with the invitation on top) andhome-empty-share(empty library, bell with badge).Need help on this PR? Tag
@codesmith-botwith what you need.Ready for batch.