feat: add support for parallel dag processor in helm#61963
feat: add support for parallel dag processor in helm#61963kush-wisdom wants to merge 4 commits intoapache:mainfrom
Conversation
Signed-off-by: kush-wisdom <241912135+kush-wisdom@users.noreply.github.com>
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
b81b6a9 to
99d58c7
Compare
|
We are in the middle of releasing Helm chart 1.19. Therefore please contribute testing and we will re-visit the PR afterwards. No hurry. |
jscheffl
left a comment
There was a problem hiding this comment.
Sorry, coming a bit late back to this PR as review. Soon will cut release 1.20. Do you want to resolve conflicts and rework/respond to comments just added?
| "type": "integer" | ||
| }, | ||
| "args": { | ||
| "description": "Args to use when running this dag processor instance (templated). Falls back to ``dagProcessor.args`` if not set.", |
There was a problem hiding this comment.
For me it does not make much sense to define multiple Dag processors and if no args given then falling back to the base. Then you would just have multiple replicas. If I decide to have multiple deployments then I'd assume there is a reason for different args == falback does not make sense in my view.
| # multipleDagProcessing: | ||
| # - name: git-dags | ||
| # replicas: 2 | ||
| # args: ["bash", "-c", "exec airflow dag-processor --subdir /opt/airflow/dags/git"] |
There was a problem hiding this comment.
For me it does not make much sense if the user must specify the full CLI here. It should rather present "additional args" and not the base shell command. Or would there be a reason to all another shell with another CLI for the use case?
This PR adds a new sub-section under dag-processor of values.yaml of the airflow helm chart to allow running multiple-dag processor as per the sub-directory #26494
I also have added tests via the help of Opus in here to make sure the changes are well-off.
Was generative AI tooling used to co-author this PR?
Generated-by: [Opus 4.5] following the guidelines
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.