-
Notifications
You must be signed in to change notification settings - Fork 16.8k
feat: add support for parallel dag processor in helm #61963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kush-wisdom
wants to merge
4
commits into
apache:main
Choose a base branch
from
kush-wisdom:add-multiple-dag-processing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+405
−5
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2473,6 +2473,21 @@ dagProcessor: | |
| # Environment variables to add to dag processor container | ||
| env: [] | ||
|
|
||
| # Multiple Dag Processing Configuration | ||
| # When defined (non-empty), creates a separate Deployment for each entry instead | ||
| # of a single dag-processor Deployment. Each entry requires a unique 'name' and | ||
| # can specify its own 'replicas' and 'args'. If 'replicas' or 'args' are not set | ||
| # for an entry, they fall back to dagProcessor.replicas and dagProcessor.args. | ||
| multipleDagProcessing: [] | ||
| # Example: | ||
| # multipleDagProcessing: | ||
| # - name: git-dags | ||
| # replicas: 2 | ||
| # args: ["bash", "-c", "exec airflow dag-processor --subdir /opt/airflow/dags/git"] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For me it does not make much sense if the user must specify the full CLI here. It should rather present "additional args" and not the base shell command. Or would there be a reason to all another shell with another CLI for the use case? |
||
| # - name: local-dags | ||
| # replicas: 1 | ||
| # args: ["bash", "-c", "exec airflow dag-processor --subdir /opt/airflow/dags/local"] | ||
|
|
||
| # Flower settings | ||
| flower: | ||
| # Enable flower. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it does not make much sense to define multiple Dag processors and if no args given then falling back to the base. Then you would just have multiple replicas. If I decide to have multiple deployments then I'd assume there is a reason for different args == falback does not make sense in my view.