Skip to content

fix(asf): give the main ruleset the review fields it needs - #2189

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:fix/asf-yaml-ruleset-reviews
Nov 18, 2026
Merged

potiuk merged 1 commit into
apache:mainfrom
potiuk:fix/asf-yaml-ruleset-reviews

Conversation

@potiuk

@potiuk potiuk commented Nov 18, 2026

Copy link
Copy Markdown
Member

Summary

After #2184 merged, main has no protection: the classic protection was removed, but the main ruleset was never created (gh api repos/apache/magpie/rules/branches/main returns nothing), so PRs merge without their required checks.

The asfyaml README states that when required_conversation_resolution is set, required_pull_request_reviews must be present as well. asfyaml builds a single pull_request rule from both, and without the review fields GitHub refuses that rule and the whole ruleset with it. The ruleset in #2184 set conversation resolution and left the reviews block commented out.

This adds required_pull_request_reviews with required_approving_review_count: 0 and dismiss_stale_reviews: false, so the approval requirement stays lifted as before. Restoring it is now a change of the count to 1; the comment says so.

Type of change

  • Other: repository configuration (.asf.yaml)

Test plan

  • The file parses, and the ruleset now carries both required_conversation_resolution and required_pull_request_reviews, as the asfyaml README requires.
  • After merge: gh api repos/apache/magpie/rules/branches/main lists the main ruleset's rules (status checks, linear history, pull request, deletion, non-fast-forward), and a PR with a failing required check shows as blocked for non-bypassing users.

🤖 Generated with Claude Code

asfyaml builds one pull-request rule from
required_conversation_resolution and required_pull_request_reviews,
and GitHub refuses that rule, and with it the whole ruleset, when the
review fields are missing. The `main` ruleset was therefore never
created after apache#2184 removed the classic protection. Add
required_pull_request_reviews with zero required approvals, which keeps
the approval requirement lifted; restoring it is now a change of the
count to 1.

Generated-by: Claude Opus 5
@potiuk potiuk added family:ci .github workflows, prek, validators capability:platform Framework / agent substrate skills (install, verify, doctor, override, status, setup bootstrap) labels Nov 18, 2026
@potiuk
potiuk merged commit 06f7af1 into apache:main Nov 18, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

capability:platform Framework / agent substrate skills (install, verify, doctor, override, status, setup bootstrap) family:ci .github workflows, prek, validators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant