Conversation
…nt-side from Tempo search Removes the fragile useTempoMetrics hook that chunked Tempo metrics API calls in 3-hour windows, along with the TEMPO_METRICS_MAX_WINDOW_SECONDS constant and the non-existent TempoMetricResult phantom import. Cost aggregation (buildCostTotal, buildCostTimeSeries, buildCostByAgent) was already working correctly via client-side computation from Tempo search traces — the metrics API path was unused and broken. Adds promCostTotalQuery() to queries.ts for future Prometheus-native cost tracking once the agentweave_cost_usd_total metric is available. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tTotalQuery Exports TEMPO_SEARCH_LIMIT and shows a muted caption on the Total Cost StatCard when traceRows hits the cap, so users see when the aggregate is sampled and may under-count. Removes dead promCostTotalQuery(). Follow-up to PR #168 review. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #162
Removes the fragile
useTempoMetricshook that chunked Tempo metrics API calls in 3-hour windows. Cost aggregation (buildCostTotal,buildCostTimeSeries,buildCostByAgent) was already working correctly via client-side computation from Tempo search traces — no metrics API needed.Changes
useTempoMetricshook andTEMPO_METRICS_MAX_WINDOW_SECONDSconstant fromuseTempo.tsTempoMetricResultimport (type was not defined anywhere — would have caused a TS error)promCostTotalQuery()toqueries.tsfor future Prometheus-native cost trackingWhat stays the same
buildCostTotal/buildCostTimeSeries/buildCostByAgentfrom Tempo trace rowsTesting
npm run buildpasses with no TypeScript errors🤖 Generated with Claude Code