Skip to content

refactor: collapse scene spit OR sites into private helpers - #127

Merged
arnoudja merged 1 commit into
masterfrom
cursor/spit-or-helpers-e1eb
Sep 28, 2026
Merged

arnoudja merged 1 commit into
masterfrom
cursor/spit-or-helpers-e1eb

Conversation

@arnoudja

Copy link
Copy Markdown
Owner

Summary

Maintainability post-#126 locked slice (#1 only): private helpers in scene.rs collapse the seven note_chemical_spit OR sites without moving the chemical-heat gate or spit tests.

Helpers

  • finalize_and_note — spoon×2 + pipette draw
  • note_spit_flags — pipette empty + filter 4-way OR
  • finalize_transfer_pair_and_note — shared tongs pour / dump solids (src τ=0, dest POUR_CONTACT_TAU_S)

note_chemical_spit de-dupe (≤1 spit/action) unchanged. apply_chemical_heat / CHEMICAL_SPIT_FRAC stay in aqueous_pipeline.

Tests

cargo test -p chemlab-core --lib → 271 passed.

Out of scope

Spit test file move (#2), FE cue (#3), Φ_V extract (#4), dilution twin collapse (#5), burner, features, reformats, re-doing #123/#126.

Open in Web Open in Cursor 

Add finalize_and_note, note_spit_flags, and finalize_transfer_pair_and_note
so spoon/pipette/filter/tongs/dump share one note path without changing
spit ≤1 de-dupe or finalize τ choices.

Co-authored-by: Arnoud <arnoudja@users.noreply.github.com>
@arnoudja
arnoudja marked this pull request as ready for review September 28, 2026 16:05
@arnoudja
arnoudja merged commit 57b4371 into master Sep 28, 2026
12 checks passed
@arnoudja
arnoudja deleted the cursor/spit-or-helpers-e1eb branch September 28, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants