Repository navigation
refactor: collapse scene spit OR sites into private helpers - #127
Merged
Merged
Conversation
Add finalize_and_note, note_spit_flags, and finalize_transfer_pair_and_note so spoon/pipette/filter/tongs/dump share one note path without changing spit ≤1 de-dupe or finalize τ choices. Co-authored-by: Arnoud <arnoudja@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maintainability post-#126 locked slice (#1 only): private helpers in
scene.rscollapse the sevennote_chemical_spitOR sites without moving the chemical-heat gate or spit tests.Helpers
finalize_and_note— spoon×2 + pipette drawnote_spit_flags— pipette empty + filter 4-way ORfinalize_transfer_pair_and_note— shared tongs pour / dump solids (src τ=0, destPOUR_CONTACT_TAU_S)note_chemical_spitde-dupe (≤1 spit/action) unchanged.apply_chemical_heat/CHEMICAL_SPIT_FRACstay inaqueous_pipeline.Tests
cargo test -p chemlab-core --lib→ 271 passed.Out of scope
Spit test file move (#2), FE cue (#3), Φ_V extract (#4), dilution twin collapse (#5), burner, features, reformats, re-doing #123/#126.