test(webhooks): fit retry-recover within the 300s gate timeout#230
Merged
Conversation
…fits the 300s gate timeout The #229 rewrite correctly fixed the deltas=0s contamination (entity_id isolation) but set EXPECT_ATTEMPTS=3, which waits for backoff 30+60+120s + 30s ticks + jitter (~330s) and overruns the run-suite per-test TEST_TIMEOUT=300s (exit 124). Default EXPECT_ATTEMPTS to 1: reject attempt 1, recover on attempt 2, validate the first real backoff interval (~30s) and the recover path — fits well inside 300s and stays deterministic. Full 3-interval ladder still available via EXPECT_ATTEMPTS=3 + larger timeouts. Keeps the entity_id isolation fix intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #229. The retry-recover rewrite fixed the real flake (deltas=0s from sibling-suite contamination, via entity_id isolation) but set EXPECT_ATTEMPTS=3, which needs ~330s (30+60+120 backoff + ticks + jitter) and overran the run-suite TEST_TIMEOUT=300s → exit 124. Default to observing 1 retry interval (reject attempt 1, recover on attempt 2): proves retry+recover with real backoff spacing, fits 300s deterministically. Isolation fix retained; full ladder available via EXPECT_ATTEMPTS=3.