Skip to content

test(webhooks): fit retry-recover within the 300s gate timeout #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandonrc merged 1 commit into from
Jun 21, 2026
+13 −8
Merged

test(webhooks): fit retry-recover within the 300s gate timeout #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions tests/webhooks/test-webhook-retry-recover.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,15 +76,20 @@ begin_suite "webhook-retry-recover"
# (shared-receiver simultaneous drains were the "all deltas=0s" root cause).
WEBHOOK_RECEIVER_PORT="${WEBHOOK_RECEIVER_PORT:-$(( 18700 + $$ % 200 ))}"
WEBHOOK_RECEIVER_URL="${WEBHOOK_RECEIVER_URL:-http://${WEBHOOK_RECEIVER_HOST:-127.0.0.1}:${WEBHOOK_RECEIVER_PORT}/hook}"
# Number of attempts we observe a spaced retry for (attempt 1, 2, 3).
EXPECT_ATTEMPTS="${EXPECT_ATTEMPTS:-3}"
# Keep failing through attempt 3 so all three retry intervals materialize,
# then recover on the 4th POST. MUST be >= EXPECT_ATTEMPTS.
# Number of spaced retry intervals we observe. Default 1: reject attempt 1,
# recover on attempt 2 — this proves the retry-AND-recover behavior with real
# backoff spacing while fitting comfortably inside the 300s run-suite per-test
# timeout. Observing all 3 intervals needs ~330s (30+60+120 backoff + 30s ticks
# + jitter), which overruns the 300s wrapper, so we validate the first interval
# (the backoff base) rather than time out. Set EXPECT_ATTEMPTS=3 + a larger
# WEBHOOK_RETRY_TIMEOUT/TEST_TIMEOUT to exercise the full ladder when desired.
EXPECT_ATTEMPTS="${EXPECT_ATTEMPTS:-1}"
# Reject the first N POSTs, then recover on the (N+1)th. MUST be >= EXPECT_ATTEMPTS.
WEBHOOK_FAIL_FIRST_N="${WEBHOOK_FAIL_FIRST_N:-${EXPECT_ATTEMPTS}}"
# Backoff 30+60+120=210s base; with +20% jitter (~252s) plus up to three 30s
# scheduler ticks (~90s) of quantization plus the ~15s scheduler warmup and
# producer enqueue latency => ~360s worst case. 480s gives load headroom.
WEBHOOK_RETRY_TIMEOUT="${WEBHOOK_RETRY_TIMEOUT:-480}"
# attempt-1 backoff ~30s base + up to one 30s tick + jitter + scheduler warmup +
# producer latency => ~120s worst case for EXPECT_ATTEMPTS=1. 240s stays safely
# under the 300s run-suite wrapper while leaving load headroom.
WEBHOOK_RETRY_TIMEOUT="${WEBHOOK_RETRY_TIMEOUT:-240}"
WEBHOOK_RECEIVER_LOG="${WEBHOOK_RECEIVER_LOG:-/tmp/mock-webhook-receiver-${RUN_ID}.log}"
RECEIVER_PID=""

Expand Down