Conversation
starsirius
reviewed
Mar 6, 2026
| remote_docker_version: | ||
| type: string | ||
| default: docker23 | ||
| default: default |
Member
There was a problem hiding this comment.
It seems jobs elsewhere (example) are still passing docker23 which may override this default set for setup-docker command. Curious if we need to update them as well.
Member
Author
There was a problem hiding this comment.
Good point! Updated docker23 to default in all places here.
…e with docker-cli 28 Changed setup-docker command default from docker23 to default (Docker 24) to fix incompatibility between hokusai's docker-cli 28 (API 1.52) and CircleCI's Docker 23 remote engine (max API 1.42). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
narikazu
force-pushed
the
narikazu/docker-version
branch
from
d264d1a to
40bfae2
Compare
starsirius
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
setup-dockercommanddefaultfromdocker23todefault(Docker 24) to fix incompatibility between hokusai's docker-cli 28 (API 1.52) and CircleCI's Docker 23 remote engine (max API 1.42).This PR fixes the issue on Exchange's CI.
Ticket
https://artsyproduct.atlassian.net/browse/PHIRE-2876