Skip to content

fix: update hokusai orb default remote docker version to be compatible with docker-cli 28 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
narikazu merged 1 commit into from
Mar 11, 2026
Merged

fix: update hokusai orb default remote docker version to be compatible with docker-cli 28 #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/hokusai/hokusai.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Orb Version 0.25.0
# Orb Version 0.26.0


version: 2.1
Expand Down Expand Up @@ -28,7 +28,7 @@ commands:
parameters:
remote_docker_version:
type: string
default: docker23
default: default
Copy link
Copy Markdown
Member

@starsirius starsirius Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems jobs elsewhere (example) are still passing docker23 which may override this default set for setup-docker command. Curious if we need to update them as well.

Copy link
Copy Markdown
Member Author

@narikazu narikazu Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Updated docker23 to default in all places here.

steps:
- setup
- setup_remote_docker:
Expand Down Expand Up @@ -62,7 +62,7 @@ commands:
parameters:
remote_docker_version:
type: string
default: docker23
default: default
working-directory:
type: string
default: ""
Expand Down Expand Up @@ -141,7 +141,7 @@ jobs:
description: Optional hokusai flags
remote_docker_version:
type: string
default: docker23
default: default
description: specify circleci remote docker version
working-directory:
type: string
Expand All @@ -163,7 +163,7 @@ jobs:
default: deploy
remote_docker_version:
type: string
default: docker23
default: default
working-directory:
type: string
default: ""
Expand Down