Skip to content

UMD, package.json, and proper deinitialization #11

Open
futpib wants to merge 3 commits into
ashl1:masterfrom
futpib:master
Open

UMD, package.json, and proper deinitialization #11
futpib wants to merge 3 commits into
ashl1:masterfrom
futpib:master

Conversation

@futpib
Copy link
Copy Markdown

@futpib futpib commented Mar 30, 2017

Motivations:

  • UMD - kinda obvious
    • Needed to use this plugin in CommonJS environment
  • package.json
    • Browserify can not load a module without package.json (I expect the same is true for webpack)
  • deinitialization, event namespacing and unbinding
    • When datatable is destroyed, rowsGroup failed to unbind it's event, and, if later you instantiate datable on the same DOM element, you get double event handling from both old and new rowsGroup instances

@futpib futpib changed the title package.json and UMD UMD, package.json, and proper deinitialization Mar 31, 2017
@ashl1
Copy link
Copy Markdown
Owner

ashl1 commented Aug 26, 2017

Argh... Only see you've already do this.
Thank with this. I want to rewrite it with ES6 and publish at npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants