fix(POR-22648): handle platform apps entity errors in notification-center - #1416
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(POR-22648): handle platform apps entity errors in notification-center#1416cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…nter Wrap notification fetch in try/catch so platform errors like 'No entity type for apps found' show a user-friendly SilentError instead of an unhandled request error in Sentry. Also use safeParse for CTA params and return early when token payload lacks notificationId. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/notification-centerwith try/catch so platform errors (e.g.No entity type for apps found) show a user-friendlySilentErrorinstead of an unhandled request error in SentrynotificationIdsafeParsefor CTA params and show a clear message when the notification is not task-linkedTesting Criteria
Notes
apps-scoped notification entity; Tasks cannot fix the platform mapping but can handle it gracefullyImpact & Surface Area of Change
/notification-centerpage only — affects IU in-product notification deep-link flow when platform returns entity-type errors