fix(POR-22652): handle platform Form.fields unmarshaling errors in notification-center - #1417
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(POR-22652): handle platform Form.fields unmarshaling errors in notification-center#1417cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
…tification-center Wrap notification-center platform API calls in try/catch so Go backend Form.fields JSON unmarshaling failures show a user-friendly SilentError instead of an unhandled request error in Sentry. Co-authored-by: Neil Raina <makeitraina@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
/notification-centernotification fetch in try/catch so platform API failures (including GoForm.fieldsJSON unmarshaling errors) show a user-friendlySilentErrorinstead of an unhandled request error in Sentry.notificationId.safeParsefor CTA params with a clear message when the notification is not task-linked.Testing Criteria
src/app/notification-center/page.tsxForm.fieldsunmarshaling error and confirm the page shows "This notification could not be opened in Tasks" instead of a 500Notes
Form.fieldsstored as JSON array vs Goforms.FormFieldsstruct). Platform team should fix the data/model; this PR only prevents Tasks from surfacing it as an unhandled error.Impact & Surface Area of Change
/notification-centerpage only — error handling for notification deep-link flow when platform API fails.