[ty] Support for custom _generate_next_value_ in enums#25196
Merged
Conversation
thejchap
requested review from
AlexWaygood,
carljm,
dcreager,
ibraheemdev and
sharkdp
as code owners
thejchap
changed the title
_generate_next_value_ in enums
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 89.36%. The percentage of expected errors that received a diagnostic held steady at 85.49%. The number of fully passing files held steady at 88/134. |
Memory usage reportSummary
Significant changesClick to expand detailed breakdownprefect
sphinx
trio
flake8
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 89ca803ca6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
| Project | Old Time | New Time | Change |
|---|---|---|---|
pandas-stubs |
9.73s | 14.72s | +51% |
thejchap
force-pushed
the
thejchap/gennextvalue
branch
from
89ca803 to
3f8aeba
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f8aeba876
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
charliermarsh
force-pushed
the
thejchap/gennextvalue
branch
from
e756d3a to
b12a65b
Compare
charliermarsh
approved these changes
May 17, 2026
charliermarsh
added a commit
that referenced
this pull request
May 17, 2026
…25210) ## Summary One oversight in my changes to #25196: if a custom `__new__` is defined, we should treat the alias value as `Any`, rather than relying on `_generate_next_value_`. This matches Pyright, for example. E.g., given: ```python class E(Enum): @staticmethod def _generate_next_value_(...) -> Literal["x"]: return "x" def __new__(cls, value: str): obj = object.__new__(cls) obj._value_ = object() return obj A = auto() B = auto() ``` Prior to this change, we treated `B` as an alias of `A`; but if `__new__` is defined, we don't attempt to detect the alias.
thejchap
added a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
…5196) ## Summary astral-sh/ty#876 This PR adds support for custom `_generate_next_value_` methods on enums. When set, this return type will take precedence over inferred `auto()` member types unless an explicit `_value_` annotation is set. Falls back to `Any` if custom hooks (like `__init__`) are detected. References: - https://typing.python.org/en/latest/spec/enums.html#member-values - https://docs.python.org/3/library/enum.html#enum.Enum._generate_next_value_ ## Test Plan New mdtests --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
thejchap
pushed a commit
to thejchap/ruff
that referenced
this pull request
May 23, 2026
…stral-sh#25210) ## Summary One oversight in my changes to astral-sh#25196: if a custom `__new__` is defined, we should treat the alias value as `Any`, rather than relying on `_generate_next_value_`. This matches Pyright, for example. E.g., given: ```python class E(Enum): @staticmethod def _generate_next_value_(...) -> Literal["x"]: return "x" def __new__(cls, value: str): obj = object.__new__(cls) obj._value_ = object() return obj A = auto() B = auto() ``` Prior to this change, we treated `B` as an alias of `A`; but if `__new__` is defined, we don't attempt to detect the alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
astral-sh/ty#876
This PR adds support for custom
_generate_next_value_methods on enums.When set, this return type will take precedence over inferred
auto()member types unless an explicit_value_annotation is set.Falls back to
Anyif custom hooks (like__init__) are detected.References:
Test Plan
New mdtests